Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add junit family to avoid pytest warning #11748

Merged
merged 1 commit into from May 11, 2020

Conversation

karthiknadig
Copy link
Member

For #10673

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@sonarcloud
Copy link

sonarcloud bot commented May 11, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-io
Copy link

codecov-io commented May 11, 2020

Codecov Report

Merging #11748 into master will decrease coverage by 0.08%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11748      +/-   ##
==========================================
- Coverage   60.71%   60.63%   -0.09%     
==========================================
  Files         629      628       -1     
  Lines       33999    33926      -73     
  Branches     4793     4778      -15     
==========================================
- Hits        20643    20570      -73     
- Misses      12350    12358       +8     
+ Partials     1006      998       -8     
Impacted Files Coverage Δ
src/client/testing/pytest/runner.ts 17.85% <50.00%> (+1.19%) ⬆️
src/datascience-ui/react-common/arePathsSame.ts 75.00% <0.00%> (-12.50%) ⬇️
src/client/common/utils/platform.ts 64.70% <0.00%> (-11.77%) ⬇️
src/client/common/utils/misc.ts 63.63% <0.00%> (-10.73%) ⬇️
src/client/common/installer/productInstaller.ts 86.16% <0.00%> (-6.67%) ⬇️
src/client/logging/transports.ts 77.77% <0.00%> (-3.48%) ⬇️
src/client/common/utils/decorators.ts 78.02% <0.00%> (-2.38%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84f9c7a...f65a53f. Read the comment docs.

Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karthiknadig karthiknadig marked this pull request as ready for review May 11, 2020 23:42
@karthiknadig
Copy link
Member Author

@karthiknadig karthiknadig merged commit 1d15bbf into microsoft:master May 11, 2020
@karthiknadig karthiknadig deleted the issue10673 branch May 12, 2020 19:05
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants