Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10790 prep - Create an experiments/ folder #11980

Merged
merged 6 commits into from
May 26, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/client/activation/aaTesting.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
'use strict';

import { inject, injectable } from 'inversify';
import { ValidateABTesting } from '../common/experimentGroups';
import { ValidateABTesting } from '../common/experiments/groups';
import { IExperimentsManager } from '../common/types';
import { IExtensionSingleActivationService } from './types';

Expand Down
2 changes: 1 addition & 1 deletion src/client/activation/activationManager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { TextDocument } from 'vscode';
import { IApplicationDiagnostics } from '../application/types';
import { IActiveResourceService, IDocumentManager, IWorkspaceService } from '../common/application/types';
import { DEFAULT_INTERPRETER_SETTING, PYTHON_LANGUAGE } from '../common/constants';
import { DeprecatePythonPath } from '../common/experimentGroups';
import { DeprecatePythonPath } from '../common/experiments/groups';
import { traceDecorators } from '../common/logger';
import { IFileSystem } from '../common/platform/types';
import { IDisposable, IExperimentsManager, IInterpreterPathService, Resource } from '../common/types';
Expand Down
2 changes: 1 addition & 1 deletion src/client/activation/activationService.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { LSNotSupportedDiagnosticServiceId } from '../application/diagnostics/ch
import { IDiagnosticsService } from '../application/diagnostics/types';
import { IApplicationShell, ICommandManager, IWorkspaceService } from '../common/application/types';
import { STANDARD_OUTPUT_CHANNEL } from '../common/constants';
import { LSControl, LSEnabled } from '../common/experimentGroups';
import { LSControl, LSEnabled } from '../common/experiments/groups';
import { traceError } from '../common/logger';
import {
IConfigurationService,
Expand Down
2 changes: 1 addition & 1 deletion src/client/activation/extensionSurvey.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
import { inject, injectable, optional } from 'inversify';
import * as querystring from 'querystring';
import { IApplicationEnvironment, IApplicationShell } from '../common/application/types';
import { ShowExtensionSurveyPrompt } from '../common/experimentGroups';
import { ShowExtensionSurveyPrompt } from '../common/experiments/groups';
import '../common/extensions';
import { traceDecorators } from '../common/logger';
import { IPlatformService } from '../common/platform/types';
Expand Down
2 changes: 1 addition & 1 deletion src/client/activation/languageClientMiddleware.ts
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ import {

import { ProvideDeclarationSignature } from 'vscode-languageclient/lib/declaration';
import { HiddenFilePrefix } from '../common/constants';
import { CollectLSRequestTiming, CollectNodeLSRequestTiming } from '../common/experimentGroups';
import { CollectLSRequestTiming, CollectNodeLSRequestTiming } from '../common/experiments/groups';
import { IConfigurationService, IExperimentsManager, IPythonExtensionBanner } from '../common/types';
import { StopWatch } from '../common/utils/stopWatch';
import { sendTelemetryEvent } from '../telemetry';
Expand Down
2 changes: 1 addition & 1 deletion src/client/api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
'use strict';

import { isTestExecution } from './common/constants';
import { DebugAdapterNewPtvsd } from './common/experimentGroups';
import { DebugAdapterNewPtvsd } from './common/experiments/groups';
import { traceError } from './common/logger';
import { IConfigurationService, IExperimentsManager, Resource } from './common/types';
import {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
import { inject, injectable } from 'inversify';
import { ConfigurationChangeEvent, DiagnosticSeverity, Uri } from 'vscode';
import { IWorkspaceService } from '../../../common/application/types';
import { DeprecatePythonPath } from '../../../common/experimentGroups';
import { DeprecatePythonPath } from '../../../common/experiments/groups';
import '../../../common/extensions';
import { IPlatformService } from '../../../common/platform/types';
import {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
import { inject, named } from 'inversify';
import { ConfigurationTarget, DiagnosticSeverity } from 'vscode';
import { IWorkspaceService } from '../../../common/application/types';
import { DeprecatePythonPath } from '../../../common/experimentGroups';
import { DeprecatePythonPath } from '../../../common/experiments/groups';
import { IDisposableRegistry, IExperimentsManager, Resource } from '../../../common/types';
import { Common, Diagnostics } from '../../../common/utils/localize';
import { IServiceContainer } from '../../../ioc/types';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { inject, named } from 'inversify';
import { DiagnosticSeverity } from 'vscode';
import { IWorkspaceService } from '../../../common/application/types';
import { CODE_RUNNER_EXTENSION_ID } from '../../../common/constants';
import { DeprecatePythonPath } from '../../../common/experimentGroups';
import { DeprecatePythonPath } from '../../../common/experiments/groups';
import { IDisposableRegistry, IExperimentsManager, IExtensions, Resource } from '../../../common/types';
import { Common, Diagnostics } from '../../../common/utils/localize';
import { IServiceContainer } from '../../../ioc/types';
Expand Down
2 changes: 1 addition & 1 deletion src/client/common/configSettings.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import { sendSettingTelemetry } from '../telemetry/envFileTelemetry';
import { IWorkspaceService } from './application/types';
import { WorkspaceService } from './application/workspace';
import { DEFAULT_INTERPRETER_SETTING, isTestExecution } from './constants';
import { DeprecatePythonPath } from './experimentGroups';
import { DeprecatePythonPath } from './experiments/groups';
import { ExtensionChannels } from './insidersBuild/types';
import { IS_WINDOWS } from './platform/constants';
import * as internalPython from './process/internal/python';
Expand Down
2 changes: 1 addition & 1 deletion src/client/common/configuration/service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { IServiceContainer } from '../../ioc/types';
import { IWorkspaceService } from '../application/types';
import { PythonSettings } from '../configSettings';
import { isUnitTestExecution } from '../constants';
import { DeprecatePythonPath } from '../experimentGroups';
import { DeprecatePythonPath } from '../experiments/groups';
import { IConfigurationService, IExperimentsManager, IInterpreterPathService, IPythonSettings } from '../types';

@injectable()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,25 +8,27 @@
import { inject, injectable, named, optional } from 'inversify';
import { parse } from 'jsonc-parser';
import * as path from 'path';
import { IConfigurationService, IHttpClient, IPythonSettings } from '../common/types';
import { sendTelemetryEvent } from '../telemetry';
import { EventName } from '../telemetry/constants';
import { IApplicationEnvironment } from './application/types';
import { EXTENSION_ROOT_DIR, STANDARD_OUTPUT_CHANNEL } from './constants';
import { NativeNotebook } from './experimentGroups';
import { traceDecorators, traceError } from './logger';
import { IFileSystem } from './platform/types';
import { sendTelemetryEvent } from '../../telemetry';
import { EventName } from '../../telemetry/constants';
import { IApplicationEnvironment } from '../application/types';
import { EXTENSION_ROOT_DIR, STANDARD_OUTPUT_CHANNEL } from '../constants';
import { traceDecorators, traceError } from '../logger';
import { IFileSystem } from '../platform/types';
import {
ABExperiments,
IConfigurationService,
ICryptoUtils,
IExperimentsManager,
IHttpClient,
IOutputChannel,
IPersistentState,
IPersistentStateFactory
} from './types';
import { sleep } from './utils/async';
import { swallowExceptions } from './utils/decorators';
import { Experiments } from './utils/localize';
IPersistentStateFactory,
IPythonSettings
} from '../types';
import { sleep } from '../utils/async';
import { swallowExceptions } from '../utils/decorators';
import { Experiments } from '../utils/localize';
import { NativeNotebook } from './groups';

const EXPIRY_DURATION_MS = 30 * 60 * 1000;
export const isDownloadedStorageValidKey = 'IS_EXPERIMENTS_STORAGE_VALID_KEY';
Expand Down
2 changes: 1 addition & 1 deletion src/client/common/serviceRegistry.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ import { AsyncDisposableRegistry } from './asyncDisposableRegistry';
import { ConfigurationService } from './configuration/service';
import { CryptoUtils } from './crypto';
import { EditorUtils } from './editor';
import { ExperimentsManager } from './experiments';
import { ExperimentsManager } from './experiments/manager';
import { FeatureDeprecationManager } from './featureDeprecationManager';
import {
ExtensionInsidersDailyChannelRule,
Expand Down
2 changes: 1 addition & 1 deletion src/client/common/utils/cacheUtils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { Uri } from 'vscode';
import '../../common/extensions';
import { IServiceContainer } from '../../ioc/types';
import { DEFAULT_INTERPRETER_SETTING } from '../constants';
import { DeprecatePythonPath } from '../experimentGroups';
import { DeprecatePythonPath } from '../experiments/groups';
import { IExperimentsManager, IInterpreterPathService, Resource } from '../types';

type VSCodeType = typeof import('vscode');
Expand Down
2 changes: 1 addition & 1 deletion src/client/datascience/context/activeEditorContext.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { IExtensionSingleActivationService } from '../../activation/types';
import { ICommandManager, IDocumentManager, IVSCodeNotebook } from '../../common/application/types';
import { PYTHON_LANGUAGE } from '../../common/constants';
import { ContextKey } from '../../common/contextKey';
import { NativeNotebook } from '../../common/experimentGroups';
import { NativeNotebook } from '../../common/experiments/groups';
import { IDisposable, IDisposableRegistry, IExperimentsManager } from '../../common/types';
import { EditorContexts } from '../constants';
import { IInteractiveWindow, IInteractiveWindowProvider, INotebookEditor, INotebookEditorProvider } from '../types';
Expand Down
2 changes: 1 addition & 1 deletion src/client/datascience/data-viewing/dataViewer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { ViewColumn } from 'vscode';

import { IApplicationShell, IWebPanelProvider, IWorkspaceService } from '../../common/application/types';
import { EXTENSION_ROOT_DIR, UseCustomEditorApi } from '../../common/constants';
import { WebHostNotebook } from '../../common/experimentGroups';
import { WebHostNotebook } from '../../common/experiments/groups';
import { traceError } from '../../common/logger';
import { IConfigurationService, IDisposable, IExperimentsManager, Resource } from '../../common/types';
import * as localize from '../../common/utils/localize';
Expand Down
2 changes: 1 addition & 1 deletion src/client/datascience/editor-integration/hoverProvider.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { inject, injectable, named } from 'inversify';
import * as vscode from 'vscode';
import { Cancellation } from '../../common/cancellation';
import { PYTHON } from '../../common/constants';
import { RunByLine } from '../../common/experimentGroups';
import { RunByLine } from '../../common/experiments/groups';
import { traceError } from '../../common/logger';
import { IExperimentsManager } from '../../common/types';
import { sleep } from '../../common/utils/async';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ import {
} from '../../common/application/types';
import { CancellationError } from '../../common/cancellation';
import { EXTENSION_ROOT_DIR, isTestExecution, PYTHON_LANGUAGE } from '../../common/constants';
import { RunByLine, WebHostNotebook } from '../../common/experimentGroups';
import { RunByLine, WebHostNotebook } from '../../common/experiments/groups';
import { traceError, traceInfo, traceWarning } from '../../common/logger';
import { IFileSystem } from '../../common/platform/types';
import { IConfigurationService, IDisposableRegistry, IExperimentsManager } from '../../common/types';
Expand Down
2 changes: 1 addition & 1 deletion src/client/datascience/ipywidgets/ipywidgetHandler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import {
LoadIPyWidgetClassLoadAction,
NotifyIPyWidgeWidgetVersionNotSupportedAction
} from '../../../datascience-ui/interactive-common/redux/reducers/types';
import { EnableIPyWidgets } from '../../common/experimentGroups';
import { EnableIPyWidgets } from '../../common/experiments/groups';
import { traceError, traceInfo } from '../../common/logger';
import { IDisposableRegistry, IExperimentsManager, IOutputChannel } from '../../common/types';
import * as localize from '../../common/utils/localize';
Expand Down
2 changes: 1 addition & 1 deletion src/client/datascience/jupyter/jupyterDebugger.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import * as vsls from 'vsls/vscode';
import { concatMultilineStringOutput } from '../../../datascience-ui/common';
import { ServerStatus } from '../../../datascience-ui/interactive-common/mainState';
import { IApplicationShell } from '../../common/application/types';
import { DebugAdapterNewPtvsd } from '../../common/experimentGroups';
import { DebugAdapterNewPtvsd } from '../../common/experiments/groups';
import { traceError, traceInfo, traceWarning } from '../../common/logger';
import { IPlatformService } from '../../common/platform/types';
import { IConfigurationService, IExperimentsManager, Version } from '../../common/types';
Expand Down
2 changes: 1 addition & 1 deletion src/client/datascience/jupyter/jupyterVariables.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import type { JSONObject } from '@phosphor/coreutils';
import { inject, injectable, named } from 'inversify';

import { Event, EventEmitter } from 'vscode';
import { RunByLine } from '../../common/experimentGroups';
import { RunByLine } from '../../common/experiments/groups';
import { IDisposableRegistry, IExperimentsManager } from '../../common/types';
import { captureTelemetry } from '../../telemetry';
import { Identifiers, Telemetry } from '../constants';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

import { inject, injectable } from 'inversify';
import { IExtensionActivationService } from '../../activation/types';
import { LocalZMQKernel } from '../../common/experimentGroups';
import { LocalZMQKernel } from '../../common/experiments/groups';
import '../../common/extensions';
import { IDisposableRegistry, IExperimentsManager, Resource } from '../../common/types';
import { swallowExceptions } from '../../common/utils/decorators';
Expand Down
2 changes: 1 addition & 1 deletion src/client/datascience/notebook/integration.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { inject, injectable } from 'inversify';
import * as path from 'path';
import { IExtensionSingleActivationService } from '../../activation/types';
import { ICommandManager, IVSCodeNotebook } from '../../common/application/types';
import { NativeNotebook } from '../../common/experimentGroups';
import { NativeNotebook } from '../../common/experiments/groups';
import { IFileSystem } from '../../common/platform/types';
import { IDisposableRegistry, IExperimentsManager, IExtensionContext } from '../../common/types';
import { noop } from '../../common/utils/misc';
Expand Down
2 changes: 1 addition & 1 deletion src/client/datascience/plotting/plotViewer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { traceInfo } from '../../../client/common/logger';
import { createDeferred } from '../../../client/common/utils/async';
import { IApplicationShell, IWebPanelProvider, IWorkspaceService } from '../../common/application/types';
import { EXTENSION_ROOT_DIR, UseCustomEditorApi } from '../../common/constants';
import { WebHostNotebook } from '../../common/experimentGroups';
import { WebHostNotebook } from '../../common/experiments/groups';
import { traceError } from '../../common/logger';
import { IFileSystem } from '../../common/platform/types';
import { IConfigurationService, IDisposable, IExperimentsManager, Resource } from '../../common/types';
Expand Down
2 changes: 1 addition & 1 deletion src/client/datascience/raw-kernel/rawNotebookProvider.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import * as uuid from 'uuid/v4';
import { Event, EventEmitter, Uri } from 'vscode';
import { CancellationToken } from 'vscode-jsonrpc';
import { ILiveShareApi } from '../../common/application/types';
import { LocalZMQKernel } from '../../common/experimentGroups';
import { LocalZMQKernel } from '../../common/experiments/groups';
import '../../common/extensions';
import { traceError, traceInfo } from '../../common/logger';
import { IAsyncDisposableRegistry, IConfigurationService, IExperimentsManager, Resource } from '../../common/types';
Expand Down
2 changes: 1 addition & 1 deletion src/client/datascience/serviceRegistry.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import { IExtensionSingleActivationService } from '../activation/types';
import { IApplicationEnvironment } from '../common/application/types';
import { UseCustomEditorApi } from '../common/constants';
import { NativeNotebook } from '../common/experimentGroups';
import { NativeNotebook } from '../common/experiments/groups';
import { IExperimentsManager } from '../common/types';
import { ProtocolParser } from '../debugger/debugAdapter/Common/protocolParser';
import { IProtocolParser } from '../debugger/debugAdapter/types';
Expand Down
2 changes: 1 addition & 1 deletion src/client/debugger/extension/adapter/factory.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import {
WorkspaceFolder
} from 'vscode';
import { IApplicationShell } from '../../../common/application/types';
import { DebugAdapterNewPtvsd } from '../../../common/experimentGroups';
import { DebugAdapterNewPtvsd } from '../../../common/experiments/groups';
import { traceVerbose } from '../../../common/logger';
import { IExperimentsManager } from '../../../common/types';
import { EXTENSION_ROOT_DIR } from '../../../constants';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { inject, injectable } from 'inversify';
import { DebugAdapterTracker, DebugAdapterTrackerFactory, DebugSession, ProviderResult } from 'vscode';
import { DebugProtocol } from 'vscode-debugprotocol';
import { IApplicationShell } from '../../../common/application/types';
import { DebugAdapterNewPtvsd } from '../../../common/experimentGroups';
import { DebugAdapterNewPtvsd } from '../../../common/experiments/groups';
import { IBrowserService, IExperimentsManager } from '../../../common/types';
import { Common, OutdatedDebugger } from '../../../common/utils/localize';
import { IPromptShowState } from './types';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
import { inject, injectable } from 'inversify';
import { CancellationToken, Uri, WorkspaceFolder } from 'vscode';
import { IDocumentManager, IWorkspaceService } from '../../../../common/application/types';
import { DebugAdapterNewPtvsd } from '../../../../common/experimentGroups';
import { DebugAdapterNewPtvsd } from '../../../../common/experiments/groups';
import { IPlatformService } from '../../../../common/platform/types';
import { IConfigurationService, IExperimentsManager } from '../../../../common/types';
import { Diagnostics } from '../../../../common/utils/localize';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
'use strict';

import { inject, injectable } from 'inversify';
import { DebugAdapterNewPtvsd, WebAppReload } from '../../../../common/experimentGroups';
import { DebugAdapterNewPtvsd, WebAppReload } from '../../../../common/experiments/groups';
import { traceInfo } from '../../../../common/logger';
import { IExperimentsManager } from '../../../../common/types';
import { sendTelemetryEvent } from '../../../../telemetry';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

import { inject, injectable } from 'inversify';
import * as path from 'path';
import { UseTerminalToGetActivatedEnvVars } from '../../common/experimentGroups';
import { UseTerminalToGetActivatedEnvVars } from '../../common/experiments/groups';
import '../../common/extensions';
import { traceError } from '../../common/logger';
import { IFileSystem } from '../../common/platform/types';
Expand Down
2 changes: 1 addition & 1 deletion src/client/interpreter/autoSelection/rules/settings.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

import { inject, injectable } from 'inversify';
import { IWorkspaceService } from '../../../common/application/types';
import { DeprecatePythonPath } from '../../../common/experimentGroups';
import { DeprecatePythonPath } from '../../../common/experiments/groups';
import { IFileSystem } from '../../../common/platform/types';
import { IExperimentsManager, IInterpreterPathService, IPersistentStateFactory, Resource } from '../../../common/types';
import { AutoSelectionRule, IInterpreterAutoSelectionService } from '../types';
Expand Down
2 changes: 1 addition & 1 deletion src/client/interpreter/autoSelection/rules/workspaceEnv.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
import { inject, injectable, named } from 'inversify';
import { Uri } from 'vscode';
import { IWorkspaceService } from '../../../common/application/types';
import { DeprecatePythonPath } from '../../../common/experimentGroups';
import { DeprecatePythonPath } from '../../../common/experiments/groups';
import { traceVerbose } from '../../../common/logger';
import { IFileSystem, IPlatformService } from '../../../common/platform/types';
import { IExperimentsManager, IInterpreterPathService, IPersistentStateFactory, Resource } from '../../../common/types';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

import { inject, injectable } from 'inversify';
import { Disposable, Uri } from 'vscode';
import { DeprecatePythonPath } from '../../../common/experimentGroups';
import { DeprecatePythonPath } from '../../../common/experiments/groups';
import { IExperimentsManager, IPathUtils, Resource } from '../../../common/types';
import { IInterpreterSecurityService } from '../../autoSelection/types';
import { IInterpreterService, PythonInterpreter } from '../../contracts';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { inject, injectable } from 'inversify';
import { Uri } from 'vscode';
import { IWorkspaceService } from '../../common/application/types';
import { DeprecatePythonPath } from '../../common/experimentGroups';
import { DeprecatePythonPath } from '../../common/experiments/groups';
import { IExperimentsManager, IInterpreterPathService } from '../../common/types';
import { IServiceContainer } from '../../ioc/types';
import { GlobalPythonPathUpdaterService } from './services/globalUpdaterService';
Expand Down
Loading