Fix raw kernel running other languages #12111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix connection file clashing
rchiodo
requested review from
IanMatthewHuff,
DonJayamanne,
greazer,
DavidKutu,
joyceerhl and
techwithtim
|
Duh I forgot to mention, I also made it possible to switch kernels without having a notebook open. This allows the user to actually switch to a kernel that works in case the one in the notebook won't start. |
rchiodo
commented
Jun 2, 2020
| @@ -46,11 +47,19 @@ export class NotebookProvider implements INotebookProvider { | |||
| disposables.push( | |||
| interactiveWindowProvider.onDidChangeActiveInteractiveWindow(this.checkAndDisposeNotebook, this) | |||
| ); | |||
| // this.rawNotebookProvider | |||
There was a problem hiding this comment.
This is used if the initial kernel doesn't run. After I fixed the kernel running I didn't hit this again.
In reply to: 434219118 [](ancestors = 434219118)
There was a problem hiding this comment.
Maybe I should write a test that mimics a failure in the kernel on startup.
In reply to: 434219880 [](ancestors = 434219880,434219118)
DonJayamanne
approved these changes
Jun 2, 2020
src/test/datascience/jupyter/kernels/kernelSwitcher.unit.test.ts
Outdated
Show resolved
Hide resolved
IanMatthewHuff
approved these changes
Jun 2, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
DonJayamanne
approved these changes
Jun 3, 2020
DavidKutu
approved these changes
Jun 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #11919
This finishes the work to support other languages. Note, there's no tests for it. (other than some basic unit tests for kernel picking). We don't install dotnet on the azure machine nor do we test the language tokenization.
I feel like this is okay at this time as we're not officially supporting any other languages yet.
I'm going to add another issue for 'testing' other languages.
https://github.com/microsoft/vscode-python/issues/12112