Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate python envs component registration #12776

Merged
merged 7 commits into from Jul 7, 2020
Merged

Consolidate python envs component registration #12776

merged 7 commits into from Jul 7, 2020

Conversation

karthiknadig
Copy link
Member

Register all injectable classes from the pythonEnvironments component from a single place.

@karthiknadig karthiknadig added the no-changelog No news entry required label Jul 6, 2020
ericsnowcurrently
ericsnowcurrently approved these changes Jul 6, 2020
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Yep, that is exactly what I was thinking of. I have some suggestions for naming, to make it the "legacy" code more obvious, but I'll leave it up to you. :)

src/client/pythonEnvironments/main.ts Outdated Show resolved Hide resolved
src/client/extensionInit.ts Outdated Show resolved Hide resolved
@karthiknadig karthiknadig marked this pull request as ready for review July 6, 2020 23:37
@sonarcloud
Copy link

sonarcloud bot commented Jul 7, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@karthiknadig karthiknadig merged commit 8894487 into microsoft:master Jul 7, 2020
@karthiknadig karthiknadig deleted the consolidate branch July 21, 2020 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

@kimadeline kimadeline kimadeline approved these changes

Assignees
No one assigned
Labels
no-changelog No news entry required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@karthiknadig @ericsnowcurrently @kimadeline