Show tensor dimensions in variable explorer #14244
Conversation
joyceerhl
requested review from
IanMatthewHuff,
DonJayamanne,
greazer,
jmew,
rchiodo and
DavidKutu
Codecov Report
@@ Coverage Diff @@
## main #14244 +/- ##
==========================================
- Coverage 59.96% 59.96% -0.01%
==========================================
Files 706 706
Lines 39180 39180
Branches 5681 5681
==========================================
- Hits 23494 23493 -1
- Misses 14449 14450 +1
Partials 1237 1237
Continue to review full report at Codecov.
|
| @@ -5,6 +5,21 @@ | |||
| import builtins as _VSCODE_builtins | |||
| import vscodeDataFrameHelpers as _VSCODE_dataFrameHelpers | |||
|
|
|||
|
|
|||
| def maybeParseTensorShape(var, result): | |||
There was a problem hiding this comment.
With all of our variable fetching code we prefixed with VSCODE to avoid conflict with something the user has define. I would think that we would need this here are well.
| def maybeParseTensorShape(var, result): | ||
| try: | ||
| vartype = type(var) | ||
| if (hasattr(vartype, "__name__")) and vartype.__name__ == "Tensor": |
There was a problem hiding this comment.
Should we add a simple test for this?
There was a problem hiding this comment.
@DonJayamanne do you mean a Python test or a Typescript test? And would that involve installing PyTorch on the build machines?
|
Kudos, SonarCloud Quality Gate passed!
|
…-jupyter (#194) * Fix sample notebook to state that you can double click to edit a cell (#14238) * Disable surveys if running in codespaces (#14332) * Disable surveys if running in codespaces * Disable gather survey in codespaces too * For gather, show a description without the survey * Fixes for IW tests where UIKind is not defined * Fix all the tests where UIKind is not defined * Appease hygiene * Disable mailing list if running in Codespaces (#14347) * Show tensor dimensions in variable explorer (#14244) * Fix markdown cell marker formatting for export to Python (#14360)
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).