Update the initialization of the PythonEnvInfoCache to pass in a function that checks for env info completeness #14446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion that checks for env info completeness
Codecov Report
@@ Coverage Diff @@
## main #14446 +/- ##
===========================================
- Coverage 59.19% 0.00% -59.20%
===========================================
Files 720 15 -705
Lines 40211 39 -40172
Branches 5829 3 -5826
===========================================
- Hits 23802 0 -23802
+ Misses 15147 39 -15108
+ Partials 1262 0 -1262
Continue to review full report at Codecov.
|
|
Kudos, SonarCloud Quality Gate passed!
|
karthiknadig
approved these changes
Oct 20, 2020
kimadeline
approved these changes
Oct 20, 2020
luabud
pushed a commit
to luabud/vscode-python
that referenced
this pull request
Oct 26, 2020
…tion that checks for env info completeness (microsoft#14446) * Update the initialization of the PythonEnvInfoCache to pass in a function that checks for env info completeness * Update interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EnvCache needs to know if interpreterInfo.py has been run or not.