Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PythonInterpreterLocatorService and other classes only when in experiment #15152

Merged
merged 14 commits into from Jan 15, 2021

Conversation

karrtikr
Copy link

@karrtikr karrtikr commented Jan 14, 2021

Because registerLegacyDiscoveryForIOC is now an async function, I had to propogate async all the way up everywhere.

@karrtikr karrtikr added the no-changelog No news entry required label Jan 14, 2021
@karrtikr karrtikr marked this pull request as ready for review January 15, 2021 01:00
@github-actions github-actions bot requested a review from int19h January 15, 2021 01:01
@karrtikr karrtikr changed the title Only use PythonInterpreterLocatorService when in experiment Register and use PythonInterpreterLocatorService only when in experiment Jan 15, 2021
@codecov-io
Copy link

codecov-io commented Jan 15, 2021

Codecov Report

Merging #15152 (e8f5b9b) into main (db6cd4b) will decrease coverage by 0%.
The diff coverage is 60%.

@@          Coverage Diff           @@
##            main   #15152   +/-   ##
======================================
- Coverage     65%      65%   -1%     
======================================
  Files        561      561           
  Lines      26525    26540   +15     
  Branches    3803     3806    +3     
======================================
+ Hits       17271    17277    +6     
- Misses      8552     8560    +8     
- Partials     702      703    +1     
Impacted Files Coverage Δ
src/client/interpreter/contracts.ts 100% <ø> (ø)
src/client/interpreter/interpreterService.ts 62% <20%> (-2%) ⬇️
src/client/pythonEnvironments/legacyIOC.ts 37% <80%> (+1%) ⬆️

@karrtikr karrtikr changed the title Register and use PythonInterpreterLocatorService only when in experiment Use PythonInterpreterLocatorService and other classes only when in experiment Jan 15, 2021
src/client/pythonEnvironments/legacyIOC.ts Outdated Show resolved Hide resolved
src/client/interpreter/interpreterService.ts Outdated Show resolved Hide resolved
src/client/interpreter/interpreterService.ts Outdated Show resolved Hide resolved
@karrtikr karrtikr merged commit b155be4 into microsoft:main Jan 15, 2021
@karrtikr karrtikr deleted the pythonlocator branch January 15, 2021 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants