forked from DonJayamanne/pythonVSCode
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use PythonInterpreterLocatorService and other classes only when in experiment #15152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karrtikr
changed the title
Only use PythonInterpreterLocatorService when in experiment
Register and use PythonInterpreterLocatorService only when in experiment
Jan 15, 2021
Codecov Report
@@ Coverage Diff @@
## main #15152 +/- ##
======================================
- Coverage 65% 65% -1%
======================================
Files 561 561
Lines 26525 26540 +15
Branches 3803 3806 +3
======================================
+ Hits 17271 17277 +6
- Misses 8552 8560 +8
- Partials 702 703 +1
|
karrtikr
changed the title
Register and use PythonInterpreterLocatorService only when in experiment
Use PythonInterpreterLocatorService and other classes only when in experiment
Jan 15, 2021
karthiknadig
requested changes
Jan 15, 2021
karthiknadig
approved these changes
Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
registerLegacyDiscoveryForIOC
is now an async function, I had to propogateasync
all the way up everywhere.