Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if file exists instead of launching it #15726

Merged
merged 2 commits into from
Mar 19, 2021

Conversation

DonJayamanne
Copy link

@DonJayamanne DonJayamanne commented Mar 19, 2021

For #15725

@DonJayamanne DonJayamanne added the skip tests Updates to tests unnecessary label Mar 19, 2021
@codecov-io
Copy link

Codecov Report

Merging #15726 (13775eb) into main (3ca66f9) will increase coverage by 0%.
The diff coverage is 50%.

@@          Coverage Diff           @@
##            main   #15726   +/-   ##
======================================
  Coverage     64%      64%           
======================================
  Files        557      557           
  Lines      26730    26725    -5     
  Branches    3887     3887           
======================================
- Hits       17292    17291    -1     
+ Misses      8708     8704    -4     
  Partials     730      730           
Impacted Files Coverage Δ
src/client/common/configSettings.ts 69% <50%> (+<1%) ⬆️
src/client/providers/jediProxy.ts 23% <0%> (ø)
src/client/common/platform/fileSystem.ts 80% <0%> (ø)
src/client/common/installer/poetryInstaller.ts 95% <0%> (ø)
...nts/discovery/locators/services/condaEnvService.ts 80% <0%> (ø)
...discovery/locators/services/condaEnvFileService.ts 85% <0%> (ø)

@DonJayamanne DonJayamanne merged commit c91b414 into microsoft:main Mar 19, 2021
@DonJayamanne DonJayamanne deleted the issue15725 branch March 19, 2021 23:35
karthiknadig pushed a commit to karthiknadig/vscode-python that referenced this pull request Mar 22, 2021
@karrtikr
Copy link

Introduced #15782

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip tests Updates to tests unnecessary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants