Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add survey for MPLS usage #16403

Merged
merged 3 commits into from Jun 7, 2021
Merged

Add survey for MPLS usage #16403

merged 3 commits into from Jun 7, 2021

Conversation

jakebailey
Copy link
Member

@jakebailey jakebailey commented Jun 5, 2021 •
edited

This is modeled on #16069 and the main survey banner.

@jakebailey jakebailey marked this pull request as ready for review June 7, 2021 19:39
@jakebailey jakebailey added the no-changelog No news entry required label Jun 7, 2021
@karthiknadig karthiknadig self-requested a review June 7, 2021 20:21
karrtikr
karrtikr reviewed Jun 7, 2021
View reviewed changes
Copy link

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should remove updateMemento() in favor of using built in diagnostic command API, LGTM otherwise.

src/client/application/diagnostics/checks/mplsSurvey.ts Outdated Show resolved Hide resolved
src/client/application/diagnostics/checks/mplsSurvey.ts Outdated Show resolved Hide resolved
@jakebailey
Copy link
Member Author

Working on refactoring to use the commands and ditch the memento, testing is just not fun.

@jakebailey
Copy link
Member Author

Refactored. This relies on the assumption that diagnose only runs once on startup, and that ignore with global ignores for all time.

@jakebailey
Copy link
Member Author

@karrtikr Can you take a look to see if the current state is reasonable? I am not super familiar with this new diagnostic infrastructure.

karrtikr
karrtikr approved these changes Jun 7, 2021
View reviewed changes
Copy link

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/client/application/diagnostics/checks/mplsSurvey.ts Show resolved Hide resolved
@jakebailey jakebailey merged commit feb02c6 into microsoft:main Jun 7, 2021
@jakebailey jakebailey deleted the mpls-survey branch June 7, 2021 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karthiknadig karthiknadig karthiknadig approved these changes

@karrtikr karrtikr karrtikr approved these changes

@paulacamargo25 paulacamargo25 paulacamargo25 approved these changes

Assignees

@kimadeline kimadeline

Labels
no-changelog No news entry required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jakebailey @karthiknadig @karrtikr @paulacamargo25 @kimadeline