Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we can change interpreters after trusting a workspace #19353

Merged
merged 1 commit into from Jun 23, 2022

Conversation

karrtikr
Copy link

@karrtikr karrtikr commented Jun 23, 2022

ConfigSettings is a static class and so wasn't being deregistered properly when extension is deactivated, so it was still using the reference to older singletons before deactivation.

@karrtikr karrtikr added bug Issue identified by VS Code Team member as probable bug skip tests Updates to tests unnecessary labels Jun 23, 2022
@karrtikr karrtikr changed the title Ensure we can change interpreters after moving from untrusted to trusted Ensure we can change interpreters after trusting a workspace Jun 23, 2022
@karthiknadig
Copy link
Member

@heejaechang this should address the interpreter change issue you were seeing.

@karrtikr karrtikr merged commit 36e24e0 into microsoft:main Jun 23, 2022
@karrtikr karrtikr deleted the fixtrust branch June 23, 2022 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug skip tests Updates to tests unnecessary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants