Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix buttons in the interpreter quickpick list #19611

Merged
merged 8 commits into from
Aug 4, 2022

Conversation

karrtikr
Copy link

@karrtikr karrtikr commented Aug 2, 2022

For #19621

Change refresh icon when interpreter list is refreshing:
spinner

Add a back button in Enter Interpreter path... options: image

@karrtikr karrtikr added the feature-request Request for new features or functionality label Aug 2, 2022
@karrtikr karrtikr marked this pull request as ready for review August 2, 2022 21:01
karthiknadig
karthiknadig previously approved these changes Aug 3, 2022
@karrtikr
Copy link
Author

karrtikr commented Aug 3, 2022

Checked with Miguel who recommended using the spinning loading octicon:

loadingspinner

karthiknadig
karthiknadig previously approved these changes Aug 3, 2022
@karrtikr
Copy link
Author

karrtikr commented Aug 3, 2022

@karthiknadig Sorry, CI failed, please re-review.

@karrtikr karrtikr merged commit 93fd4e8 into microsoft:main Aug 4, 2022
@karrtikr karrtikr deleted the refreshing branch August 4, 2022 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants