Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check telemetry metadata in CI #19738

Merged
merged 9 commits into from
Aug 26, 2022
Merged

Check telemetry metadata in CI #19738

merged 9 commits into from
Aug 26, 2022

Conversation

brettcannon
Copy link
Member

This is in hopes of preventing things like 5cfa71d from happening again.

@brettcannon brettcannon self-assigned this Aug 25, 2022
@brettcannon brettcannon added the debt Covers everything internal: CI, testing, refactoring of the codebase, etc. label Aug 25, 2022
@brettcannon brettcannon marked this pull request as ready for review August 26, 2022 00:15
lramos15
lramos15 approved these changes Aug 26, 2022
View reviewed changes
Copy link
Member

@lramos15 lramos15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We do similar actions in the VS Code Engineer extension template

@brettcannon brettcannon merged commit 3ebf810 into main Aug 26, 2022
@brettcannon brettcannon deleted the check-telemetry branch August 26, 2022 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lramos15 lramos15 lramos15 approved these changes

Assignees

@brettcannon brettcannon

Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brettcannon @lramos15