Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove isort extension dependency #20577

Merged
merged 4 commits into from Feb 6, 2023
Merged

Remove isort extension dependency #20577

merged 4 commits into from Feb 6, 2023

Conversation

karthiknadig
Copy link
Member

@karthiknadig karthiknadig commented Jan 26, 2023 •
edited

Closes #20586

@karthiknadig karthiknadig added the feature-request Request for new features or functionality label Jan 26, 2023
@karthiknadig karthiknadig force-pushed the remove-isort branch 2 times, most recently from da7cfda to c88e114 Compare February 6, 2023 20:25
@karthiknadig karthiknadig marked this pull request as ready for review February 6, 2023 23:40
@VSCodeTriageBot VSCodeTriageBot added this to the February 2023 milestone Feb 6, 2023
@karthiknadig karthiknadig merged commit cd6ca9d into microsoft:main Feb 6, 2023
@karthiknadig karthiknadig deleted the remove-isort branch February 6, 2023 23:56
@bariod
Copy link

bariod commented Mar 2, 2023

The extension dependency is still being mentioned in the README

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eleanorjboyd eleanorjboyd eleanorjboyd approved these changes

Assignees

@karthiknadig karthiknadig

Labels
feature-request Request for new features or functionality
Projects
None yet
Milestone
February 2023
Development

Successfully merging this pull request may close these issues.

Remove dependency on isort
4 participants
@karthiknadig @bariod @eleanorjboyd @VSCodeTriageBot