Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix title and placeholder for python selection when using create env command #20896

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Fix title and placeholder for python selection when using create env command #20896

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/client/common/utils/localize.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,7 +440,7 @@ export namespace CreateEnv {
export const created = l10n.t('Environment created...');
export const installingPackages = l10n.t('Installing packages...');
export const errorCreatingEnvironment = l10n.t('Error while creating virtual environment.');
export const selectPythonQuickPickTitle = l10n.t('Select a python to use for environment creation');
export const selectPythonPlaceHolder = l10n.t('Select a python to create the virtual environment');
export const providerDescription = l10n.t('Creates a `.venv` virtual environment in the current workspace');
export const error = l10n.t('Creating virtual environment failed with error.');
export const tomlExtrasQuickPickTitle = l10n.t('Select optional dependencies to install from pyproject.toml');
Expand Down
2 changes: 2 additions & 0 deletions src/client/pythonEnvironments/creation/provider/venvCreationProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,8 @@ export class VenvCreationProvider implements CreateEnvironmentProvider {
{
skipRecommended: true,
showBackButton: true,
placeholder: CreateEnv.Venv.selectPythonPlaceHolder,
title: null,
},
);
} catch (ex) {
Expand Down