Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Remove hack to check the vscode version" #21294

Merged
merged 1 commit into from
May 24, 2023
Merged

Revert "Remove hack to check the vscode version" #21294

merged 1 commit into from
May 24, 2023

Conversation

karrtikr
Copy link

@karrtikr karrtikr commented May 24, 2023 •
edited

Reverts #21180
For #20769

@karrtikr karrtikr added debt Covers everything internal: CI, testing, refactoring of the codebase, etc. skip package*.json package.json and package-lock.json don't both need updating skip tests Updates to tests unnecessary labels May 24, 2023
@karrtikr karrtikr marked this pull request as ready for review May 24, 2023 17:52
@VSCodeTriageBot VSCodeTriageBot added this to the May 2023 milestone May 24, 2023
@karrtikr karrtikr merged commit c9a7268 into main May 24, 2023
46 of 49 checks passed
@karrtikr karrtikr deleted the revert-21180-20769-remove-hack-in-tests branch May 24, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connor4312 connor4312 connor4312 approved these changes

Assignees

@karrtikr karrtikr

Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc. skip package*.json package.json and package-lock.json don't both need updating skip tests Updates to tests unnecessary
Projects
None yet
Milestone
May 2023
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@karrtikr @connor4312 @VSCodeTriageBot