Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve shell identifier on case-insensitive system #22391

Merged
merged 2 commits into from Nov 7, 2023

Conversation

JamzumSum
Copy link

Use case-insensitive regex to remove .exe extension.

See: #22036 (comment)

Copy link

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, can you please add a testcase for this?

@karrtikr karrtikr added the bug Issue identified by VS Code Team member as probable bug label Oct 31, 2023
@karrtikr
Copy link

karrtikr commented Oct 31, 2023

For eg. you can add one here:

shellPathsAndIdentification.set('c:\\windows\\system32\\bash.exe', TerminalShellType.bash);

Use case-insensitive regex to remove `.exe`  extension.

microsoft#22036 (comment)
in case of the incoming path is case-insensitive
@JamzumSum
Copy link
Author

For eg. you can add one here:

shellPathsAndIdentification.set('c:\\windows\\system32\\bash.exe', TerminalShellType.bash);

Sure. A case-sensitive input is added in the test case now.

@JamzumSum
Copy link
Author

@microsoft-github-policy-service agree

Copy link

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karrtikr karrtikr changed the title improve shell identify on case-insensitive system Improve shell identifier on case-insensitive system Nov 1, 2023
@karrtikr karrtikr merged commit 67b4801 into microsoft:main Nov 7, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants