New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve shell identifier on case-insensitive system #22391
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, can you please add a testcase for this?
For eg. you can add one here: vscode-python/src/test/common/terminals/shellDetectors/shellDetectors.unit.test.ts Line 32 in 8e09243
|
Use case-insensitive regex to remove `.exe` extension. microsoft#22036 (comment)
in case of the incoming path is case-insensitive
Sure. A case-sensitive input is added in the test case now. |
@microsoft-github-policy-service agree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Use case-insensitive regex to remove
.exe
extension.See: #22036 (comment)