Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix venv activation for cshell #22852

Merged
merged 1 commit into from Feb 5, 2024
Merged

Fix venv activation for cshell #22852

merged 1 commit into from Feb 5, 2024

Conversation

karrtikr
Copy link

@karrtikr karrtikr commented Feb 5, 2024

Closes #22822

Use current shell to figure out whether shell integration is working, even when using fallback shell for getting environment variables.

@karrtikr karrtikr added bug Issue identified by VS Code Team member as probable bug skip tests Updates to tests unnecessary labels Feb 5, 2024
@VSCodeTriageBot VSCodeTriageBot added this to the February 2024 milestone Feb 5, 2024
@karrtikr karrtikr merged commit 8aaa70e into main Feb 5, 2024
67 checks passed
@karrtikr karrtikr deleted the kartik/tremendous-firefly branch February 5, 2024 10:57
anthonykim1 pushed a commit that referenced this pull request Feb 6, 2024
Closes #22822

Use current shell to figure out whether shell integration is working,
even when using fallback shell for getting environment variables.
@SSujitX
Copy link

SSujitX commented Feb 28, 2024

same issue on my Windows vs code and Python latest version;

Python virtual environment was successfully activated, even though "(.venv)" indicator may not be present in the terminal prompt. Learn more.

using PowerShell

powershell

@tuhinn108
Copy link

I am also facing same issue, venv not activating

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug skip tests Updates to tests unnecessary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terminal no longer activates virtual environment for csh/tcsh shell
5 participants