Add hook to vscode_pytest to determine number xdist workers to use based on count of selected tests
#23539
Conversation
DetachHead
force-pushed
the
pytest-xdist-num-workers
branch
from
d8d9a0d
to
00f953b
Compare
karthiknadig
added
the
bug
|
@DetachHead Thanks for the fix. It looks like this is causing test failures. Let me know if you are able to address these. |
|
@karthiknadig would you be able to point me to some documentation for how to set up this project for local development? i tried using the devcontainer but i can't get docker to work on my PC unfortunately, so i wasn't able to debug the tests |
|
Hi @DetachHead, here are the steps to getting started, these are how I set up my dev environment so hopefully that will work for you too! To debug those tests you should be able to use the testing panel to run / debug the tests, let me know if it isn't working or is confusing and I can provide some extra direction. Thanks!! |
DetachHead
force-pushed
the
pytest-xdist-num-workers
branch
2 times, most recently
from
2f1a5a5
to
1f6fa68
Compare
…ers to use based on how many tests are selected
DetachHead
force-pushed
the
pytest-xdist-num-workers
branch
from
1f6fa68
to
6661ed1
Compare
DetachHead
force-pushed
the
pytest-xdist-num-workers
branch
from
6661ed1
to
6277810
Compare
|
i got the tests passing, but i have no idea what's up with the formatter. i tried formatting it with ruff and it made a bunch of changes to code i didn't touch. (i also tried black because the wiki said so before i realized that the CI uses ruff, does that need to be updated to say ruff instead?) ideally ruff should be a dev dependency of this project, and there would be committed vscode config to make it format on save to match what the CI would do. |
|
@DetachHead sorry about that. i will fix the formatting. We have a debt item to update both linting and formatting to ruff with config added to repo. We are mid transition. |
DetachHead
force-pushed
the
pytest-xdist-num-workers
branch
2 times, most recently
from
50dd822
to
f2648de
Compare
…to_num_workers` hook because the `pytest_configure` hook didn't work for some reason
DetachHead
force-pushed
the
pytest-xdist-num-workers
branch
from
f2648de
to
f05dc0f
Compare
karthiknadig
changed the title
vscode_pytest to determine number xdist workers to use based on count of selected tests
|
so i just realized that this will crash if the user runs pytest with any ideas on how to work around this? if not, i'm happy to close this PR and try again once that issue is resolved. |
Head branch was pushed to by a user without write access
|
nvm, i got it working |
…e based on count of selected tests (#23539) fixes microsoft/vscode-python-debugger#336 --------- Co-authored-by: detachhead <detachhead@users.noreply.github.com> Co-authored-by: Karthik Nadig <kanadig@microsoft.com>
…e based on count of selected tests (microsoft#23539) fixes microsoft/vscode-python-debugger#336 --------- Co-authored-by: detachhead <detachhead@users.noreply.github.com> Co-authored-by: Karthik Nadig <kanadig@microsoft.com>
fixes microsoft/vscode-python-debugger#336