Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose API to get command for launching debugger in remote debug mode #3399

Merged
merged 3 commits into from Nov 20, 2018
Merged

Expose API to get command for launching debugger in remote debug mode #3399

merged 3 commits into from Nov 20, 2018

Conversation

DonJayamanne
Copy link

For #3121

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Unit tests & system/integration tests are added/updated
  • [no] Test plan is updated as appropriate
  • [no] package-lock.json has been regenerated by running npm install (if dependencies have changed)

d3r3kk
d3r3kk approved these changes Nov 20, 2018
View reviewed changes
Copy link

@d3r3kk d3r3kk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with some suggestions for your consideration.

src/client/api.ts Outdated Show resolved Hide resolved
src/client/debugger/debugAdapter/DebugClients/LocalDebugClient.ts Outdated Show resolved Hide resolved
src/client/debugger/debugAdapter/DebugClients/launcherProvider.ts Show resolved Hide resolved
src/client/extension.ts Outdated Show resolved Hide resolved
@DonJayamanne DonJayamanne merged commit 0ab1384 into microsoft:master Nov 20, 2018
@DonJayamanne DonJayamanne deleted the issue3121API branch December 14, 2018 22:08
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@d3r3kk d3r3kk d3r3kk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DonJayamanne @d3r3kk