Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor how version information is stored against interpreter information #3812

Merged
merged 11 commits into from Dec 27, 2018
Merged

Refactor how version information is stored against interpreter information #3812

merged 11 commits into from Dec 27, 2018

Conversation

DonJayamanne
Copy link

For #3369

After #3809

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • [no] Has a news entry file (remember to thank yourself!)
  • Unit tests & system/integration tests are added/updated
  • [no] Test plan is updated as appropriate
  • [no] package-lock.json has been regenerated by running npm install (if dependencies have changed)

@DonJayamanne DonJayamanne added the no-changelog No news entry required label Dec 26, 2018
@DonJayamanne DonJayamanne mentioned this pull request Dec 26, 2018
Merged
8 tasks
@DonJayamanne DonJayamanne added no-changelog No news entry required and removed no-changelog No news entry required labels Dec 27, 2018
d3r3kk
d3r3kk approved these changes Dec 27, 2018
View reviewed changes
Copy link

@d3r3kk d3r3kk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to see convertPythonVersionToSemver get some unit test attention. Otherwise, this PR looks great. I do appreciate the large amount of work it took to replace this functionality with SemVer!

(Again, pending testing-success is assumed).

@DonJayamanne DonJayamanne merged commit cdf2313 into microsoft:master Dec 27, 2018
@DonJayamanne DonJayamanne deleted the refactorVersion branch May 24, 2019 20:23
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@d3r3kk d3r3kk d3r3kk approved these changes

Assignees
No one assigned
Labels
no-changelog No news entry required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DonJayamanne @d3r3kk