Match dots in ignorePatterns globs; fixes .venv not being ignored #3948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, the default `**/site-packages/**/*.py` ignorePattern fails to ignore site-packages in the .venv directory (a standard directory name for virtual environments, which even this project recommends using)
|
|
Codecov Report
@@ Coverage Diff @@
## master #3948 +/- ##
=======================================
+ Coverage 78% 78% +1%
=======================================
Files 402 406 +4
Lines 18572 19560 +988
Branches 2985 3241 +256
=======================================
+ Hits 14352 15251 +899
- Misses 4218 4307 +89
Partials 2 2
Continue to review full report at Codecov.
|
DonJayamanne
approved these changes
Jan 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #3947. Verified the plugin now ignores .venv.
Unit tests & system/integration tests are added/updatedTest plan is updated as appropriatepackage-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)