Activation of multiple parts of the extension for multiple workspaces #4052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4052 +/- ##
=======================================
- Coverage 79% 79% -<1%
=======================================
Files 407 408 +1
Lines 18677 18763 +86
Branches 3013 3031 +18
=======================================
+ Hits 14645 14690 +45
- Misses 4029 4070 +41
Partials 3 3
|
8 tasks
DonJayamanne
requested changes
Jan 19, 2019
DonJayamanne
requested changes
Jan 21, 2019
karrtikr
force-pushed
the
kartik3502
branch
3 times, most recently
from
3cb85e2
to
c3933f6
Compare
|
Please can you not mix too many issues into one PR. |
karrtikr
commented
Jan 22, 2019
karrtikr
changed the title
karrtikr
force-pushed
the
kartik3502
branch
3 times, most recently
from
317e04a
to
dddc769
Compare
DonJayamanne
requested changes
Jan 23, 2019
Co-Authored-By: karrtikr <karraj@microsoft.com>
DonJayamanne
approved these changes
Jan 23, 2019
DonJayamanne
pushed a commit
that referenced
this pull request
Jan 25, 2019
…#4052) * Acrtivate multiple workspaces * Fix typos * Auto-select virtual environment in multi-root workspaces * News Entry * Fixed hygiene * code reviews * Added tests * Corrected functionality and modified tests * Corrected hygiene * Corrected hygiene * Update src/client/activation/activationManager.ts Co-Authored-By: karrtikr <karraj@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #3501 #3502
Part 4 of #3502
Test plan is updated as appropriatepackage-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)