Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect shell in VSCode using the VSC API #6403

Merged
merged 14 commits into from Jul 10, 2019
Merged

Detect shell in VSCode using the VSC API #6403

merged 14 commits into from Jul 10, 2019

Conversation

DonJayamanne
Copy link

@DonJayamanne DonJayamanne commented Jul 1, 2019 •
edited

For #6050

Depends on #6401

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • [n/a] Test plan is updated as appropriate
  • [n/a] package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • [n/a] The wiki is updated with any design decisions/details.

@DonJayamanne DonJayamanne force-pushed the issue6050Part2 branch 6 times, most recently from 6514b6c to 307aea1 Compare July 1, 2019 23:09
@WSLUser WSLUser mentioned this pull request Jul 3, 2019
Closed
@karrtikr karrtikr self-assigned this Jul 3, 2019
karrtikr
karrtikr approved these changes Jul 3, 2019
View reviewed changes
Copy link

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏👏

@DonJayamanne DonJayamanne force-pushed the issue6050Part2 branch 2 times, most recently from b77d18d to ff9124b Compare July 8, 2019 20:10
@DonJayamanne DonJayamanne merged commit 47db2f7 into microsoft:master Jul 10, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jul 29, 2019
@DonJayamanne DonJayamanne deleted the issue6050Part2 branch September 29, 2019 21:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@karrtikr karrtikr karrtikr approved these changes

Assignees

@karrtikr karrtikr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DonJayamanne @karrtikr