Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "pathMappings" in "launch" debug configs. #7024

Conversation

ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented Aug 19, 2019

(for #3568)

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • [ ] Test plan is updated as appropriate
  • [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • [ ] The wiki is updated with any design decisions/details.

@kimadeline kimadeline self-requested a review August 20, 2019 17:40
@codecov-io
Copy link

codecov-io commented Aug 21, 2019

Codecov Report

Merging #7024 into master will increase coverage by 0.08%.
The diff coverage is 86.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7024      +/-   ##
==========================================
+ Coverage   58.29%   58.38%   +0.08%     
==========================================
  Files         483      483              
  Lines       21347    21421      +74     
  Branches     3445     3474      +29     
==========================================
+ Hits        12445    12507      +62     
- Misses       8124     8141      +17     
+ Partials      778      773       -5
Impacted Files Coverage Δ
src/client/debugger/types.ts 100% <ø> (ø) ⬆️
...bugger/extension/configuration/resolvers/attach.ts 79.24% <100%> (-3.3%) ⬇️
src/client/common/platform/platformService.ts 33.33% <33.33%> (-9.17%) ⬇️
src/client/common/utils/platform.ts 88.23% <75%> (-11.77%) ⬇️
...bugger/extension/configuration/resolvers/launch.ts 88.09% <77.77%> (-1.52%) ⬇️
...debugger/extension/configuration/resolvers/base.ts 96.77% <94.73%> (-1.01%) ⬇️
src/client/common/logger.ts 68.55% <0%> (-4.41%) ⬇️
src/client/linters/baseLinter.ts 80.34% <0%> (-1.37%) ⬇️
...atascience/interactive-window/interactiveWindow.ts 7.38% <0%> (-0.04%) ⬇️
src/client/common/configSettings.ts 57.54% <0%> (ø) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2b626b...241316a. Read the comment docs.

Copy link

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to understand the test code before merging it. Things seem a bit magical.

@ericsnowcurrently
Copy link
Member Author

As far as I can tell, the current CI failures here are unrelated to this PR.

@karrtikr
Copy link

@ericsnowcurrently You will have to rebase from master branch.

@ericsnowcurrently ericsnowcurrently merged commit a0094d4 into microsoft:master Aug 26, 2019
@ericsnowcurrently ericsnowcurrently deleted the fix-3568-launch-pathmappings branch August 26, 2019 20:42
@lock lock bot locked as resolved and limited conversation to collaborators Sep 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants