Skip to content

Commit

Permalink
Add argument to collect js-debug native verbose log (#1971)
Browse files Browse the repository at this point in the history
* Update marketpace badge service

* Add argument to collect js-debug native verbose log
  • Loading branch information
EzioLi01 committed Jun 12, 2023
1 parent 8e54e66 commit 2d89fb4
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 0 deletions.
8 changes: 8 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -863,6 +863,10 @@
"type": "object",
"description": "%reactNative.attach.sourceMapsPathOverrides.description%"
},
"jsDebugTrace": {
"type": "boolean",
"description": "%reactNative.direct.attach.jsDebugTrace.description%"
},
"sourceMapRenames": {
"type": "boolean",
"description": "%reactNative.attach.sourceMapRenames.description%",
Expand Down Expand Up @@ -952,6 +956,10 @@
"description": "%reactNative.direct.attach.useHermesEngine.description%",
"default": true
},
"jsDebugTrace": {
"type": "boolean",
"description": "%reactNative.direct.attach.jsDebugTrace.description%"
},
"cwd": {
"type": "string",
"description": "%reactNative.launch.cwd.description%",
Expand Down
1 change: 1 addition & 0 deletions package.nls.json
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@
"reactNative.direct.attach.webkitRangeMax.description": "End of port range to use for iOS device selection.",
"reactNative.direct.attach.port.description": "Port to attach to for debugging. Default for React Native Packager - 8081, for iOS Webkit Debug Proxy - 9221.",
"reactNative.direct.attach.useHermesEngine.description": "Whether to use Hermes engine for direct debugging. Default value is ‘true’",
"reactNative.direct.attach.jsDebugTrace.description": "Collect vscode-js-debug verbose trace",
"reactNative.attach.remoteRoot.description": "The source root of the remote host.",
"reactNative.attach.localRoot.description": "The local source root that corresponds to the 'remoteRoot'.",
"reactNative.attach.skipFiles.description": "An array of file or folder names, or glob patterns, to skip when debugging.",
Expand Down
1 change: 1 addition & 0 deletions src/debugger/debugSessionBase.ts
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ export interface IAttachRequestArgs
skipFiles?: [];
sourceMaps?: boolean;
sourceMapPathOverrides?: { [key: string]: string };
jsDebugTrace?: boolean;
}

export interface ILaunchRequestArgs
Expand Down
3 changes: 3 additions & 0 deletions src/debugger/jsDebugConfigAdapter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,9 @@ export class JsDebugConfigAdapter {
if (attachArgs.skipFiles) {
existingExtraArgs.skipFiles = attachArgs.skipFiles;
}
if (attachArgs.jsDebugTrace) {
existingExtraArgs.trace = attachArgs.jsDebugTrace;
}

return existingExtraArgs;
}
Expand Down

0 comments on commit 2d89fb4

Please sign in to comment.