Skip to content

Commit

Permalink
Merge pull request #1928 from microsoft/benjaminbi/issue1927
Browse files Browse the repository at this point in the history
[Feature] Workaround localization test issue caused by Vscode 1.76.0
  • Loading branch information
benjaminbi committed Mar 13, 2023
2 parents 81f731b + bc955ce commit 4b32238
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions test/localization/localization.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,21 +6,21 @@ import { ErrorHelper } from "../../src/common/error/errorHelper";
import { InternalErrorCode } from "../../src/common/error/internalErrorCode";

suite("localizationTest", function () {
suite.skip("localizationContext", function () {
suite("localizationContext", function () {
const commandFailedErrorChs = ErrorHelper.getInternalError(
InternalErrorCode.CommandFailed,
"IncorrectCommand",
);
const iosDeployErrorChs = ErrorHelper.getInternalError(InternalErrorCode.IOSDeployNotFound);
test("localize should show correct message on Russian for CommandFailed error", (done: Mocha.Done) => {
test("localize should show correct message on ZH-CN for CommandFailed error", (done: Mocha.Done) => {
assert.strictEqual(
commandFailedErrorChs.message,
"执行命令 IncorrectCommand 时出错 (error code 101)",
);
done();
});

test("localize should show correct message on Russian for iOSDeployNotFound error", (done: Mocha.Done) => {
test("localize should show correct message on ZH-CN for iOSDeployNotFound error", (done: Mocha.Done) => {
assert.strictEqual(
iosDeployErrorChs.message,
"找不到 iOS 部署。请确保全局安装该部署(npm install -g ios-deploy) (error code 201)",
Expand Down
2 changes: 1 addition & 1 deletion test/localization/runTest.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ async function launchTests() {
extensionDevelopmentPath,
extensionTestsPath,
launchArgs: ["--locale", "zh-cn"],
version: "stable",
version: "1.75.0",
});
} catch (err) {
console.error(err);
Expand Down

0 comments on commit 4b32238

Please sign in to comment.