Remove all Experimental tags for Hermes debugging #2094

microsoft · Jan 24, 2024 · 6ad9254 · 6ad9254
1 parent b18c109
commit 6ad9254
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/package.json b/package.json
@@ -342,7 +342,7 @@
       },
       {
         "command": "reactNative.debugScenario.debugInHermesExponentExperimental",
-        "title": "Debug in Hermes Exponent - Experimental",
+        "title": "Debug in Hermes Exponent",
         "category": "React Native",
         "enablement": "!config.security.workspace.trust.enabled && !inDebugMode || isWorkspaceTrusted && !inDebugMode",
         "icon": "$(debug-alt)"

diff --git a/src/extension/debuggingConfiguration/debugScenarioNameGenerator.ts b/src/extension/debuggingConfiguration/debugScenarioNameGenerator.ts
@@ -40,7 +40,7 @@ export class DebugScenarioNameGenerator {
             );
         }
 
-        if (platformType === PlatformType.ExpoWeb) {
+        if (platformType === PlatformType.ExpoWeb || !useHermesEngine) {
             isExperimental = true;
         }
 

diff --git a/src/extension/debuggingConfiguration/reactNativeDebugConfigProvider.ts b/src/extension/debuggingConfiguration/reactNativeDebugConfigProvider.ts
@@ -232,7 +232,6 @@ export class ReactNativeDebugConfigProvider implements vscode.DebugConfiguration
                         state.config.type,
                         state.config.platform,
                         state.config.useHermesEngine !== false,
-                        true,
                     );
                 }
             } else {