Add recipe for Chrome Debugging with Angular CLI #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I'm having difficulties to get this to work. In your steps you say:
After running My question: is just the description reversed or does this really work for you in the way the description says? |
|
Good catch, yes I need to switch that around. I'll push a commit with that change. |
|
And breakpoints do not work me (so they stay grey = unverified). I tried to add a "sourceMapPathOverrides" attribute but that doesn't make a difference. |
|
There seems to be a glitch in the debugger extension which requires you to refresh the browser in order to hit the breakpoint. I account for that in the instructions. |
|
No, refreshing the browser doesn't make a difference. Neither is the breakpoint hit, nor does the breakpoint turn red (= verified). I'm on macOS 10.12.5 using VS Code 1.13.0, Debugger for Chrome 3.1.3, and Chrome 60.0.3112.24 |
|
This is the trace.txt output: Maybe you can compare that with your trace and find out why it is failing for me. |
|
I have the same setup as you do. |
|
I updated the README with PR #3. |
|
Hang tight .. I'm comparing our log files. |
|
Here is my log file: |
|
And |
|
Not sure if these apply, but I found a couple of SO posts that may be relevant: VS code breakpoints failing to trigger using Debugger for Chrome |
auchenberg
reviewed
Jun 13, 2017
| "webRoot": "${workspaceRoot}", | ||
| "sourceMaps": true, | ||
| "trace": true, | ||
| "userDataDir": "${workspaceRoot}/.vscode/chrome" |
There was a problem hiding this comment.
The "userDataDir" and "sourceMaps" options are no longer needed as they are set by default
Also we probably want to disable "trace" to avoid spamming peoples logs.
There was a problem hiding this comment.
Agreed .. Removed these in PR #5: Remove sourceMaps, trace, userDataDir from launch.json.
|
@tonysneed I just tried the recipe on a fresh Windows 10 and breakpoints do not work (which basically means that debugging does not work). So I don't understand why it is working for you and not for me. @auchenberg does it work for you (on any platform)? BTW, my versions are: |
|
I'll also try the recipe on a fresh Win 10 image and see if I can hit the breakpoints.
|
|
@tonysneed I've noticed that the inlined launch.json from the readme.md was already out of sync with the launch.json in the .vscode and I've fixed that. Since you are not referring to the launch.json file in the readme, I've removed it to make it less prone to become outdated. I do the same in the MERN starter recipe. |
|
I just tried the John Papa's sample from the original feature request and there breakpoints work fine. Three findings:
|
|
Indeed, it works for me after downgrading to 1.0.6. So until we have found and fixed issue #7 we should change the readme to install explicitly @angular-cli@1.0.6 and we should add a "note" why the recipe does not use the latest version. Please see at the bottom of https://github.com/weinand/vscode-recipes/tree/master/MERN-Starter how I make notes. |
|
@weinand Sounds good. 👍 I'll be happy to add the notes. |
|
@tonysneed I've written a draft blog post that I'd love your feedback on: https://medium.com/@auchenberg/super-charged-live-editing-and-javascript-debugging-for-angular-using-visual-studio-code-c29da251ec71 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a recipe with a launch.json file and a README.md file for Chrome Debugging with Angular CLI.