Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong sleep configuration when adding configuration files for alpine container #1394

Closed
CrazySky2121 opened this issue Sep 10, 2019 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug containers Issue in vscode-remote containers

Comments

@CrazySky2121
Copy link

CrazySky2121 commented Sep 10, 2019

For example we have docker-compose.yml file with alpine based web container.

When we use Remote-Containers: Add Development Container Configuration Files from docker-compose and choose web container we have created .devcontainer/docker-compose.yml with following content in command key:

# Overrides default command so things don't shut down after the process ends. command: sleep infinity

But Alpine doesn't support infinity arg for sleep command and therefore our container failed to run with exit code 1.
Instead of this following content must be in command for same behavior as infinity:

# Overrides default command so things don't shut down after the process ends. command: sleep 3600

Steps to Reproduce:

  1. Setup latest Alpine Linux with docker-compose.yml
  2. Run Remote-Containers: Add Development Container Configuration Files and choose from docker-compose.yml
@Chuxel Chuxel self-assigned this Sep 10, 2019
@Chuxel Chuxel added bug Issue identified by VS Code Team member as probable bug containers Issue in vscode-remote containers labels Sep 10, 2019
@Chuxel
Copy link
Member

Chuxel commented Sep 10, 2019

@October21 Good catch! Will update.

Chuxel added a commit to microsoft/vscode-dev-containers that referenced this issue Sep 10, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug containers Issue in vscode-remote containers
Projects
None yet
Development

No branches or pull requests

2 participants