Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent system from sleeping while the server is running #7127

Closed
connor4312 opened this issue Aug 26, 2022 · 2 comments · Fixed by microsoft/vscode#172043
Closed

Prevent system from sleeping while the server is running #7127

connor4312 opened this issue Aug 26, 2022 · 2 comments · Fixed by microsoft/vscode#172043
Assignees
@connor4312
Labels
code-server Issues on the VS Code Server. feature-request Request for new features or functionality on-testplan
Milestone
January 2023

Comments

@connor4312
Copy link
Member

Suggested via user feedback, I think this makes good sense. If a user expects their machine to be remotely available, it should not automatically go to sleep.
@connor4312 connor4312 added the code-server Issues on the VS Code Server. label Aug 26, 2022
@connor4312 connor4312 self-assigned this Aug 26, 2022
@tanhakabir tanhakabir added the feature-request Request for new features or functionality label Aug 30, 2022
@tanhakabir tanhakabir added this to the Backlog milestone Aug 30, 2022
@connor4312 connor4312 mentioned this issue Sep 15, 2022
Closed
@bamurtaugh
Copy link
Member

bamurtaugh commented Jan 11, 2023 •
edited
Loading

I think @chrisdias and I are observing something related.

We both had remote machines where we enabled remote access, and we shut those machines down in some way (I just enabled tunnel access on another laptop and then shut the lid). Remote Tunnels still lists the machine as online, but when I try to connect, it is stuck trying to connect and eventually times out after a few minutes:

image

Not sure if there's a way to reflect the machine as offline if we'll be unable to connect to it?

@connor4312 connor4312 modified the milestones: Backlog, January 2023 Jan 20, 2023
connor4312 added a commit to microsoft/vscode that referenced this issue Jan 20, 2023
@connor4312
cli: add --no-sleep flag, implementation for macos
8270d10 
First part of microsoft/vscode-remote-release#7127
@connor4312 connor4312 mentioned this issue Jan 20, 2023
Merged
connor4312 added a commit to microsoft/vscode that referenced this issue Jan 20, 2023
@connor4312
cli: add --no-sleep flag, implementation for macos (#171885)
4cf496e 
First part of microsoft/vscode-remote-release#7127
This was referenced Jan 21, 2023
Merged
Merged
connor4312 added a commit to microsoft/vscode that referenced this issue Jan 23, 2023
@connor4312
cli: add option to enable --no-sleep for tunnel
e58ca08 
Fixes microsoft/vscode-remote-release#7127

Also add auth logs for debugging, seemed like my OSS retained
a bad Github token.
@connor4312 connor4312 mentioned this issue Jan 23, 2023
Merged
@connor4312
Copy link
Member Author

This is now done:

  • When enabling remote tunnel access from the UI, you can set remote.tunnels.access.preventSleep to stop the computer from sleeping
  • When running from the CLI, you can pass the flag --no-sleep

connor4312 added a commit to microsoft/vscode that referenced this issue Jan 23, 2023
@connor4312
cli: add option to enable --no-sleep for tunnel (#172043)
6d59c82 
Fixes microsoft/vscode-remote-release#7127

Also add auth logs for debugging, seemed like my OSS retained
a bad Github token.
TylerLeonhardt pushed a commit to microsoft/vscode that referenced this issue Jan 23, 2023
@connor4312 @TylerLeonhardt
cli: add option to enable --no-sleep for tunnel (#172043)
32264cd 
Fixes microsoft/vscode-remote-release#7127

Also add auth logs for debugging, seemed like my OSS retained
a bad Github token.
@connor4312 connor4312 mentioned this issue Jan 24, 2023
Closed
3 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Mar 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@connor4312 connor4312

Labels
code-server Issues on the VS Code Server. feature-request Request for new features or functionality on-testplan
Projects
None yet
Milestone
January 2023
Development

Successfully merging a pull request may close this issue.

cli: add option to enable --no-sleep for tunnel microsoft/vscode
3 participants
@connor4312 @tanhakabir @bamurtaugh