Incorrect URL percent decoding (%3 is stripped) when browser is opened remotely #9841
Labels
author-verification-requested
Issues potentially verifiable by issue author
bug
Issue identified by VS Code Team member as probable bug
remote
Issues in the code server support
verified
Verification succeeded
Milestone
Steps to Reproduce:
samply load profile.json
.Expected results:
A browser should open on my client with that URL.
In this case the URL should have been
https://profiler.firefox.com/from-url/http%3A%2F%2F127.0.0.1%3A3001%2F3swmpxx3xvzrh762ym3gf2vyb3l8cq98cd18k0kFprofile.json/?symbolServer=http%3A%2F%2F127.0.0.1%3A3001%2F3swmpxx3xvzrh762ym3gf2vyb3l8cq98cd18k0k
Actual results:
A browser opens on my client with a different URL.
In this case the URL that opened instead is
https://profiler.firefox.com/from-url/httpAFF127.0.0.1A3001F3swmpxx3xvzrh762ym3gf2vyb3l8cq98cd18k0kFprofile.json/?symbolServer=httpAFF127.0.0.1A3001F3swmpxx3xvzrh762ym3gf2vyb3l8cq98cd18k0k
The incorrect URL has all instances of
%2
and%3
stripped from it. This breaks any URL-encoded characters.Specifically,
http%3A%2F%2F127.0.0.1%3A3001%2F
has becomehttpAFF127.0.0.1A3001F
.Does this issue occur when you try this locally?: No
Does this issue occur when you try this locally and all extensions are disabled?: Didn't try
This issue does not occur if the remote server is a macOS or Linux machine. I've only seen it with the host being Windows.
The text was updated successfully, but these errors were encountered: