Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rename and enable additional tools #3

Merged
merged 16 commits into from
Jun 28, 2019
Merged

Conversation

alitari
Copy link
Contributor

@alitari alitari commented Jun 15, 2019

Fix rename

In order to fix the "symbol rename" function, the workdir is part of the GOPATH now. To demonstrate this functionality an additional package has been created.

Tools for:

  • extracting variable/function
  • generating interface stubs
  • generating tests
  • initializing structs
  • adding json tags
  • sending code to go playground

@msftclas
Copy link

msftclas commented Jun 15, 2019

CLA assistant check
All CLA requirements met.

@Chuxel
Copy link
Member

Chuxel commented Jun 20, 2019

@alitari Thanks for the contribution! Are any of the dockerfile updates things we should also consider for the general Go container at https://github.com/Microsoft/vscode-dev-containers (that is used by the VS Code UI)?

@alitari
Copy link
Contributor Author

alitari commented Jun 25, 2019

@Chuxel : imho, yes. All the tools added here are part of the functionality in the ms-vscode.go extension. Only the change for using the language language server and infer gopath is a bit questionable, because i'm not sure whether this works well with go modules.

@Chuxel Chuxel merged commit ccd88f5 into microsoft:master Jun 28, 2019
@Chuxel
Copy link
Member

Chuxel commented Jun 28, 2019

Thanks! These changes look great. See a couple of copy-editing errors, but I'll tweak those post-merge.

Chuxel added a commit to microsoft/vscode-dev-containers that referenced this pull request Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants