Skip to content
This repository has been archived by the owner on Mar 28, 2024. It is now read-only.

Implements a code action that can fix failing deep strict equal assertions #2

Merged
merged 3 commits into from Oct 6, 2021

Conversation

hediet
Copy link
Member

@hediet hediet commented Sep 13, 2021

But only those that compare against plain JSON.

@hediet hediet requested review from connor4312 and removed request for connor4312 September 13, 2021 16:40
@hediet
Copy link
Member Author

hediet commented Sep 13, 2021

@connor4312 fyi.

I don't consider this production ready yet.

hediet added a commit to microsoft/vscode that referenced this pull request Sep 13, 2021
@hediet hediet marked this pull request as draft September 13, 2021 16:46
@hediet hediet force-pushed the hediet/failingDeepStrictEqualAssertFixer branch from a1e0b8b to 3b8657f Compare September 17, 2021 18:57
@hediet hediet marked this pull request as ready for review September 17, 2021 18:58
@hediet
Copy link
Member Author

hediet commented Sep 17, 2021

I think we can selfhost on this.

attachTestMessageMetadata is super hacky, but afaik currently the best way to do it.

@connor4312 connor4312 merged commit f489bd4 into main Oct 6, 2021
@connor4312 connor4312 deleted the hediet/failingDeepStrictEqualAssertFixer branch October 6, 2021 22:27
lemanschik pushed a commit to code-oss-dev/code that referenced this pull request Nov 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants