Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid vmArgument merging when launch.json has a list of vmArgs #95

Closed
kdvolder opened this issue Dec 20, 2019 · 2 comments
Closed

Invalid vmArgument merging when launch.json has a list of vmArgs #95

kdvolder opened this issue Dec 20, 2019 · 2 comments

Comments

@kdvolder
Copy link
Collaborator

kdvolder commented Dec 20, 2019

See: spring-projects/sts4#395 (comment)

Summary:

If we make a launch.json that has something like:

           "vmArgs": [ "-Dspring.jmx.enabled=true", "-Dspring.application.admin.enabled=true" ]

Then this launches fine using the vscode java debugger tooling directly.

However when we launch it from the Boot Dashboard then the arguments are joined together with a , in between. This changes the meaning of the arguments and causes apps launched this way to malfunction.

The culprit I think is here:

https://github.com/microsoft/vscode-spring-boot-dashboard/blob/master/src/Controller.ts#L74

I guess javascript implicitly converts the array into a string adding commas between.

kdvolder added a commit to kdvolder/vscode-spring-boot-dashboard that referenced this issue Dec 20, 2019
@Eskibear
Copy link
Member

Yes, we can directly pass an array of vmArgs to the debugger extension, which has been supported since a couple of months ago.
Thank you for the fix!

Eskibear pushed a commit that referenced this issue Dec 30, 2019
@Eskibear
Copy link
Member

shipped with v0.1.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants