Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mvnw missing execute permission #66

Closed
Eskibear opened this issue Jul 19, 2018 · 4 comments · Fixed by #85
Closed

mvnw missing execute permission #66

Eskibear opened this issue Jul 19, 2018 · 4 comments · Fixed by #85
Assignees
@Eskibear
Labels
bug fixed

Comments

@Eskibear
Copy link
Member

Eskibear commented Jul 19, 2018 •
edited
Loading

In MacOSX, file mvnw doesn't have execute permission. But if I downloads a zip from start.spring.io, and unzip if myself, it works well.
@Eskibear Eskibear added the bug label Jul 19, 2018
@Eskibear
Copy link
Member Author

Eskibear commented Sep 6, 2018

Reason: the package used to unzip the .zip file doesn't preserve file permissions.
See: mhr3/unzip-stream#18

@lrkwz
Copy link

lrkwz commented Oct 2, 2018

Same on ubuntu

@Eskibear
Copy link
Member Author

@lrkwz I think we have to manually execute chmod +x ./mvnw for the moment before we find a way to preserve permission. 🤦‍♂️

@Eskibear
Copy link
Member Author

Maybe this lib works, I'll try it later.

https://github.com/maxogden/extract-zip

@Eskibear Eskibear self-assigned this Oct 18, 2018
@Eskibear Eskibear mentioned this issue Oct 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Eskibear Eskibear

Labels
bug fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use extract-zip to unzip files with permission preserved. microsoft/vscode-spring-initializr
2 participants
@lrkwz @Eskibear