Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

declare engine: node >= 18 #25

Closed
aeschli opened this issue Feb 21, 2024 · 0 comments · Fixed by #34
Closed

declare engine: node >= 18 #25

aeschli opened this issue Feb 21, 2024 · 0 comments · Fixed by #34

Comments

@aeschli
Copy link

aeschli commented Feb 21, 2024

test-cli requires node 18 to run:

When run with node 16:

ReferenceError: structuredClone is not defined
    at DesktopPlatform.prepare (file:///tmp/9511677ff29752e82883f6d8c2c28774ed849526/testCom/node_modules/@vscode/test-cli/out/cli/platform/desktop.mjs:36:22)
    at file:///tmp/9511677ff29752e82883f6d8c2c28774ed849526/testCom/node_modules/@vscode/test-cli/out/bin.mjs:52:38
    at Array.map (<anonymous>)
    at prepareConfigs (file:///tmp/9511677ff29752e82883f6d8c2c28774ed849526/testCom/node_modules/@vscode/test-cli/out/bin.mjs:50:48)
    at runConfigs (file:///tmp/9511677ff29752e82883f6d8c2c28774ed849526/testCom/node_modules/@vscode/test-cli/out/bin.mjs:127:28)
    at main (file:///tmp/9511677ff29752e82883f6d8c2c28774ed849526/testCom/node_modules/@vscode/test-cli/out/bin.mjs:33:26)

I suggest adding an engine entry to test-cli to avoid any confusion with users.

  "engines" : { 
    "node" : ">=18.0.0"
  }
@aeschli aeschli changed the title declare engine > declare engine: node >= 18 Feb 21, 2024
connor4312 added a commit that referenced this issue Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant