Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.2.1 requires node >= 16.0 but the documentation still says 12 #181

Closed
kimadeline opened this issue Dec 6, 2022 · 2 comments · Fixed by #182
Closed

2.2.1 requires node >= 16.0 but the documentation still says 12 #181

kimadeline opened this issue Dec 6, 2022 · 2 comments · Fixed by #182
Labels
question Question instead of bug/feature-request

Comments

@kimadeline
Copy link

The newly released 2.2.1 version of the @vscode/test-electron package requires node >= 16, but the readme still says Node >= 12.x.

Will this requirement be loosened, or should projects either upgrade to Node 16 or pin vscode/test-electron to 2.2.0?
@connor4312
Copy link
Member

connor4312 commented Dec 6, 2022 •
edited

Projects should upgrade to Node 16. This is the version that VS Code runs in its extension host, so being on that version would ensure a consistent environment and avoid surprises.

Node 12 is also end of life and no longer receives security updates.

@connor4312 connor4312 added the question Question instead of bug/feature-request label Dec 6, 2022
connor4312 added a commit that referenced this issue Dec 6, 2022
@connor4312
docs: update recommend node version
fde160f 
Fixes #181
@connor4312 connor4312 mentioned this issue Dec 6, 2022
Merged
connor4312 added a commit that referenced this issue Dec 6, 2022
@connor4312
docs: update recommend node version (#182)
7a4ced3 
Fixes #181
@dfreeman
Copy link

dfreeman commented Dec 7, 2022

Node 14 is still under LTS maintenance, though, and dropping support for it in a patch release wasn't ideal 😕

dfreeman added a commit to typed-ember/glint that referenced this issue Dec 7, 2022
@dfreeman
Lock @vscode/test-electron to 2.2.0 until we drop Node 14 support
8e8845a 
microsoft/vscode-test#181
hmajoros pushed a commit to hmajoros/glint that referenced this issue Dec 15, 2022
@dfreeman
Lock @vscode/test-electron to 2.2.0 until we drop Node 14 support
6043362 
microsoft/vscode-test#181
@Eskibear Eskibear mentioned this issue Jan 18, 2023
Open
aeschli added a commit to microsoft/vscode-generator-code that referenced this issue Jan 31, 2023
@aeschli
running tests now requires 16.x (microsoft/vscode-test#181)
a494599
aeschli added a commit to microsoft/vscode-generator-code that referenced this issue Jan 31, 2023
@aeschli
running tests now requires 16.x (microsoft/vscode-test#181) (#400)
584d759
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Question instead of bug/feature-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: update recommend node version microsoft/vscode-test
3 participants
@dfreeman @connor4312 @kimadeline