Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ELECTRON_RUN_AS_NODE #16

Closed
bpasero opened this issue Jul 1, 2016 · 3 comments
Closed

Support ELECTRON_RUN_AS_NODE #16

bpasero opened this issue Jul 1, 2016 · 3 comments
Assignees
@alexdima
Labels
bug Issue identified by VS Code Team member as probable bug
Milestone
Backlog

Comments

@bpasero
Copy link
Member

bpasero commented Jul 1, 2016

Our next update of Electron will remove the deprecated ATOM_SHELL_INTERNAL_RUN_AS_NODE. To support both old and new world, I suggest to set both flags wherever you set ATOM_SHELL_INTERNAL_RUN_AS_NODE currently.
@Tyriar Tyriar mentioned this issue Jul 3, 2016
Closed
@alexdima alexdima added the bug Issue identified by VS Code Team member as probable bug label Aug 16, 2016
@alexdima alexdima added this to the Backlog milestone Aug 16, 2016
@alexdima
Copy link
Member

@bpasero What Electron version will deprecate this?

@bpasero
Copy link
Member Author

bpasero commented Aug 16, 2016

@alexandrudima anything > 1.0. (we are still on 0.37.x)

@alexdima
Copy link
Member

I removed the script that was using ATOM_SHELL_INTERNAL_RUN_AS_NODE

david-driscoll pushed a commit to OmniSharp/vscode-textmate that referenced this issue Oct 7, 2019
@DustinCampbell
Merge pull request microsoft#16 from DustinCampbell/fix-issue-refs
355a9f2 
Update all existing 'issue #nnnn' references to 'issue omnisharp-vscode#nnnn'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexdima alexdima

Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@bpasero @alexdima