Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit and update refresh scenarios of the tree view #357

Closed
shsuman opened this issue Jan 16, 2020 · 1 comment
Closed

Revisit and update refresh scenarios of the tree view #357

shsuman opened this issue Jan 16, 2020 · 1 comment
Assignees
@shsuman

Comments

@shsuman
Copy link
Member

shsuman commented Jan 16, 2020

VSCode has updated its tree view refresh function now, so even after refreshing the entire tree, it retains the current state. Jim and Rong might remember that we had some problems around the refreshing and revealing of tree nodes while setting an active workspace from another workspace

Anyways, this makes our life easier and now we can make the refresh function independent of the node and even implement it in places where we don't have access to the tree node instance. I believe we do try to refresh the tree at certain events but we just need to make sure that we are covering all events
@greazer greazer added the bug label Jan 30, 2020
@shsuman
Copy link
Member Author

shsuman commented Feb 17, 2020

Merged PR https://msasg.visualstudio.com/OpenMind%20Studio/_git/OpenMindVSCode/pullrequest/1480265

@shsuman shsuman closed this as completed Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shsuman shsuman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@greazer @shsuman