Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should upgrade lodash version to >=4.17.12 #422

Closed
yiyione opened this issue Feb 11, 2020 · 2 comments
Closed

Should upgrade lodash version to >=4.17.12 #422

yiyione opened this issue Feb 11, 2020 · 2 comments
Assignees
Milestone

Comments

@yiyione
Copy link

yiyione commented Feb 11, 2020

When I run yarn audit fix, I got a vulnerability from vsce:
│ high │ Prototype Pollution
│ Package │ lodash
│ Patched in │ >=4.17.12
│ Dependency of │ vsce
│ Path │ vsce > lodash
│ More info │ https://www.npmjs.com/advisories/1065

@joaomoreno joaomoreno self-assigned this Feb 12, 2020
@joaomoreno
Copy link
Member

Can you show me the full output of yarn audit fix? I'm getting different results.

@yiyione
Copy link
Author

yiyione commented Feb 12, 2020

I'm sorry, I didn't run yarn audit fix under vscode-vsce project, looks like it doesn't have vulnerability here.
I run it in another project, has dependency of vsce:
"devDependencies": { "vsce": "^1.73.0" }
I got this:
audit_fix

@joaomoreno joaomoreno added this to the February 2020 milestone Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants