Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCE does not package node_modules since about October 2 (version 1.81.0) #497

Closed
mmmyddd opened this issue Oct 4, 2020 · 8 comments
Closed

Comments

@mmmyddd
Copy link

mmmyddd commented Oct 4, 2020

  • Create extension
  • Run npm install to create node_modules directory
  • Run vsce package in extension directory
  • unzip .vsix file
  • No node_modules
@mmmyddd
Copy link
Author

mmmyddd commented Oct 4, 2020

I use npm and not yarn, BTW.

Just tried vsce 1.80.0 is good.

@mmmyddd mmmyddd changed the title VSCE not package node_modules since about October 2 (version 1.81.0) VSCE does not package node_modules since about October 2 (version 1.81.0) Oct 4, 2020
@felipecrs
Copy link
Contributor

Did you try with --no-yarn, so we can check if this issue is the same as #494?

@mmmyddd
Copy link
Author

mmmyddd commented Oct 5, 2020

Did you try with --no-yarn, so we can check if this issue is the same as #494?

Yes, --no-yarn helps, but pls correct this, for npm seems the default option in my point of view

Thank you.

@laike9m
Copy link

laike9m commented Oct 5, 2020

This is causing my extension to not function. There's no clear error message when building, which is even worse.

@Foxhoundn
Copy link

Foxhoundn commented Oct 5, 2020

Why was there a sudden, silent change like this, from npm to yarn? Everything in our pipelines is failing because none of our images had yarn >.<

@felipecrs
Copy link
Contributor

People, this is a bug being tracked on #494. This is not an intended change.

@felipecrs
Copy link
Contributor

It should be fixed in newest version, 1.81.1.

@joaomoreno
Copy link
Member

Dupe of #494

Sorry for the breakage yall! Fix is out there!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants