Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove win32-ia32 #908

Merged
merged 1 commit into from
Oct 27, 2023
Merged

remove win32-ia32 #908

merged 1 commit into from
Oct 27, 2023

Conversation

joaomoreno
Copy link
Member

No description provided.

@joaomoreno joaomoreno merged commit 10309ba into main Oct 27, 2023
15 checks passed
@joaomoreno joaomoreno deleted the joao/apricot-iguana branch October 27, 2023 09:56
@felipecrs
Copy link
Contributor

@joaomoreno do you mind providing a bit more context? Does this mean I should stop publishing extensions with this target?

@nvarner
Copy link

nvarner commented Nov 1, 2023

@felipecrs I ran into this as well. For partial context, I found microsoft/vscode#195559.

nvarner added a commit to nvarner/typst-lsp that referenced this pull request Nov 1, 2023
Based on microsoft/vscode-vsce#908 and microsoft/vscode#195559, it
appears that extensions should no longer be published for the now
removed win32-ia32 target.
nvarner added a commit to nvarner/typst-lsp that referenced this pull request Nov 1, 2023
Based on microsoft/vscode-vsce#908 and microsoft/vscode#195559, it
appears that extensions should no longer be published for the now
removed win32-ia32 target.
@sean-mcmanus
Copy link

sean-mcmanus commented Nov 2, 2023

@joaomoreno Our C/C++ extension can no longer build our 32-bit Windows vsix. What do you advise?

@sean-mcmanus
Copy link

sean-mcmanus commented Nov 2, 2023

@joaomoreno We downgraded to npm version 2.21.1. Let us know if you have a recommendation for when we should stop publishing the 32-bit Windows vsix (or if VS Code or the marketplace won't work with it anymore). Our VS Code requirement is currently 1.67.0 or newer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants