Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a Nan::AsyncWorker to do the work #1

Closed
Tyriar opened this issue Aug 1, 2017 · 1 comment
Closed

Use a Nan::AsyncWorker to do the work #1

Tyriar opened this issue Aug 1, 2017 · 1 comment
Assignees
@Tyriar
Labels
enhancement

Comments

@Tyriar
Copy link
Member

Tyriar commented Aug 1, 2017

No description provided.

@Tyriar Tyriar self-assigned this Aug 1, 2017
@Tyriar
Copy link
Member Author

Tyriar commented Aug 14, 2017 •
edited by Lixire

We need to make the JS API asynchronous with a callback:

// Current API
windowsProcessTree(list: [])

// New API
windowsProcessTree(list: [], cb: (tree: []) => void)

We also need the C++ native call that does I/O (process.cc) to be done inside a Nan::AsyncWorker so that it's done on a different thread.

@Lixire Lixire mentioned this issue Aug 15, 2017
Merged
Lixire added a commit that referenced this issue Aug 15, 2017
@Lixire
Make API async
5941c33 
Fixes #1
@Tyriar Tyriar closed this as completed in #4 Aug 15, 2017
vmihdal pushed a commit to vmihdal/vscode-windows-process-tree that referenced this issue Oct 26, 2020
Merge pull request microsoft#1 from volodymyrmigdal/master
b0a7171 
Master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Tyriar