Don't respect editor.fontSize: 0

toFloat only falls back to the default when the value is NaN, so an explicit check for 0 is required. Fixes #11715
microsoft · Sep 8, 2016 · 07d663d · 07d663d
1 parent 85a2337
commit 07d663d
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/src/vs/editor/common/config/commonEditorConfig.ts b/src/vs/editor/common/config/commonEditorConfig.ts
@@ -478,6 +478,9 @@ export abstract class CommonEditorConfiguration extends Disposable implements ed
 		let fontSize = toFloat(opts.fontSize, DefaultConfig.editor.fontSize);
 		fontSize = Math.max(0, fontSize);
 		fontSize = Math.min(100, fontSize);
+		if (fontSize === 0) {
+			fontSize = DefaultConfig.editor.fontSize;
+		}
 
 		let lineHeight = toInteger(opts.lineHeight, 0, 150);
 		if (lineHeight === 0) {