proxy authentication does not work on 1.49 (#106434) (#106490)

microsoft · Sep 11, 2020 · 0bff53b · 0bff53b
1 parent e790b93
commit 0bff53b
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/vs/code/electron-main/auth.ts b/src/vs/code/electron-main/auth.ts
@@ -92,9 +92,9 @@ export class ProxyAuthHandler extends Disposable {
 			if (channel === 'vscode:proxyAuthResponse') {
 				const { username, password } = credentials;
 				cb(username, password);
+				win.removeListener('close', onWindowClose);
+				win.close();
 			}
-			win.removeListener('close', onWindowClose);
-			win.close();
 		});
 		win.loadURL(url);
 	}