Merge branch 'master' into bugfix-ts-completion-modifiers

.github/commands.json

@@ -305,5 +305,31 @@
 		"action": "close",
 		"addLabel": "*caused-by-extension",
 		"comment": "It looks like this is caused by the Docker extension. Please file it with the repository [here](https://github.com/microsoft/vscode-docker). Make sure to check their issue reporting template and provide them relevant information such as the extension version you're using. See also our [issue reporting](https://aka.ms/vscodeissuereporting) guidelines for more information.\n\nHappy Coding!"
+	},
+	{
+		"type": "comment",
+		"name": "extJava",
+		"allowUsers": [
+			"cleidigh",
+			"usernamehw",
+			"gjsjohnmurray",
+			"IllusionMH"
+		],
+		"action": "close",
+		"addLabel": "*caused-by-extension",
+		"comment": "It looks like this is caused by the Java extension. Please file it with the repository [here](https://github.com/redhat-developer/vscode-java). Make sure to check their [troubleshooting instructions](https://github.com/redhat-developer/vscode-java/wiki/Troubleshooting) and provide relevant information such as the extension version you're using. See also our [issue reporting](https://aka.ms/vscodeissuereporting) guidelines for more information.\n\nHappy Coding!"
+	},
+	{
+		"type": "comment",
+		"name": "extJavaDebug",
+		"allowUsers": [
+			"cleidigh",
+			"usernamehw",
+			"gjsjohnmurray",
+			"IllusionMH"
+		],
+		"action": "close",
+		"addLabel": "*caused-by-extension",
+		"comment": "It looks like this is caused by the Java Debugger extension. Please file it with the repository [here](https://github.com/Microsoft/vscode-java-debug). Make sure to check their issue reporting template and provide them relevant information such as the extension version you're using. See also our [issue reporting](https://aka.ms/vscodeissuereporting) guidelines for more information.\n\nHappy Coding!"
 	}
 ]

.github/disabled_workflows/needs-more-info-labeler.yml

@@ -11,7 +11,7 @@ jobs:
         uses: actions/checkout@v2
         with:
           repository: 'JacksonKearl/vscode-triage-github-actions'
-          ref: v19
+          ref: v21
       - name: Run Needs More Info Labeler
         uses: ./needs-more-info-labeler
         with:

.github/workflows/author-verified.yml

@@ -15,7 +15,7 @@ jobs:
         uses: actions/checkout@v2
         with:
           repository: 'JacksonKearl/vscode-triage-github-actions'
-          ref: v19
+          ref: v21
           path: ./actions
       - name: Checkout Repo
         if: github.event_name != 'issues' || contains(github.event.issue.labels.*.name, 'author-verification-requested')

.github/workflows/commands.yml

@@ -13,7 +13,7 @@ jobs:
         uses: actions/checkout@v2
         with:
           repository: 'JacksonKearl/vscode-triage-github-actions'
-          ref: v19
+          ref: v21
       - name: Run Commands
         uses: ./commands
         with:

.github/workflows/copycat.yml

@@ -11,7 +11,7 @@ jobs:
         uses: actions/checkout@v2
         with:
           repository: 'JacksonKearl/vscode-triage-github-actions'
-          ref: v19
+          ref: v21
       - name: Run CopyCat (JacksonKearl/testissues)
         uses: ./copycat
         with:

.github/workflows/feature-request.yml

@@ -0,0 +1,36 @@
+name: Feature Request Manager
+on:
+  repository_dispatch:
+  issues:
+    types: [labeled, milestoned]
+  schedule:
+    - cron: 20 2 * * * # 4:20am Zurich
+
+jobs:
+  main:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout Actions
+        if: github.event_name != 'issues' || contains(github.event.issue.labels.*.name, 'feature-request')
+        uses: actions/checkout@v2
+        with:
+          repository: 'JacksonKearl/vscode-triage-github-actions'
+          ref: v21
+      - name: Run Feature Request Manager
+        if: github.event_name != 'issues' || contains(github.event.issue.labels.*.name, 'feature-request')
+        uses: ./feature-request
+        with:
+          token: ${{secrets.VSCODE_ISSUE_TRIAGE_BOT_PAT}}
+          candidateMilestoneID: 107
+          candidateMilestoneName: Backlog Candidates
+          backlogMilestoneID: 8
+          featureRequestLabel: feature-request
+          upvotesRequired: 20
+          numCommentsOverride: 20
+          initComment: "This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our [documentation](https://aka.ms/vscode-issue-lifecycle).\n\nHappy Coding!"
+          warnComment: "This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our [documentation](https://aka.ms/vscode-issue-lifecycle).\n\nHappy Coding"
+          acceptComment: ":slightly_smiling_face: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our [documentation](https://aka.ms/vscode-issue-lifecycle).\n\nHappy Coding!"
+          rejectComment: ":slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our [documentation](https://aka.ms/vscode-issue-lifecycle).\n\nHappy Coding!"
+          warnDays: 10
+          closeDays: 60
+          milestoneDelaySeconds: 60

.github/workflows/locker.yml

@@ -18,7 +18,7 @@ jobs:
         uses: actions/checkout@v2
         with:
           repository: 'JacksonKearl/vscode-triage-github-actions'
-          ref: v19
+          ref: v21
       - name: Run Locker
         uses: ./locker
         with:

.github/workflows/needs-more-info-closer.yml

@@ -12,7 +12,7 @@ jobs:
         uses: actions/checkout@v2
         with:
           repository: 'JacksonKearl/vscode-triage-github-actions'
-          ref: master
+          ref: v21
       - name: Run Needs More Info Closer
         uses: ./needs-more-info-closer
         with:

.github/workflows/new-release.yml

@@ -11,7 +11,7 @@ jobs:
         uses: actions/checkout@v2
         with:
           repository: 'JacksonKearl/vscode-triage-github-actions'
-          ref: v19
+          ref: v21
       - name: Run New Release
         uses: ./new-release
         with:

.github/workflows/test-plan-item-validator.yml

@@ -12,7 +12,7 @@ jobs:
         uses: actions/checkout@v2
         with:
           repository: 'JacksonKearl/vscode-triage-github-actions'
-          ref: v19
+          ref: v21
       - name: Run Test Plan Item Validator
         if: contains(github.event.issue.labels.*.name, 'testplan-item') || contains(github.event.issue.labels.*.name, 'invalid-testplan-item')
         uses: ./test-plan-item-validator

.vscode/searches/es6.code-search

@@ -2,7 +2,7 @@
 # Flags: CaseSensitive WordMatch
 # ContextLines: 2
 
-11 results - 3 files
+9 results - 4 files
 
 src/vs/base/common/arrays.ts:
   401  
@@ -17,20 +17,14 @@ src/vs/base/common/arrays.ts:
   420   */
   421  export function first<T>(array: ReadonlyArray<T>, fn: (item: T) => boolean, notFoundValue: T): T;
 
-  474  
-  475  /**
-  476:  * @deprecated ES6: use `Array.fill`
-  477   */
-  478  export function fill<T>(num: number, value: T, arr: T[] = []): T[] {
-
-  571  
-  572  /**
-  573:  * @deprecated ES6: use `Array.find`
-  574   */
-  575  export function find<T>(arr: ArrayLike<T>, predicate: (value: T, index: number, arr: ArrayLike<T>) => any): T | undefined {
+  560  
+  561  /**
+  562:  * @deprecated ES6: use `Array.find`
+  563   */
+  564  export function find<T>(arr: ArrayLike<T>, predicate: (value: T, index: number, arr: ArrayLike<T>) => any): T | undefined {
 
 src/vs/base/common/map.ts:
-  9  
+   9  
   10  /**
   11:  * @deprecated ES6: use `[...SetOrMap.values()]`
   12   */
@@ -42,33 +36,28 @@ src/vs/base/common/map.ts:
   23   */
   24  export function keys<K, V>(map: Map<K, V>): K[] {
 
-  58  
-  59  /**
-  60:  * @deprecated ES6: use `...Map.entries()`
-  61   */
-  62  export function mapToSerializable(map: Map<string, string>): [string, string][] {
-
-  71  
-  72  /**
-  73:  * @deprecated ES6: use `new Map([[key1, value1],[key2, value2]])`
-  74   */
-  75  export function serializableToMap(serializable: [string, string][]): Map<string, string> {
+src/vs/base/common/objects.ts:
+  115  
+  116  /**
+  117:  * @deprecated ES6
+  118   */
+  119  export function assign<T>(destination: T): T;
 
 src/vs/base/common/strings.ts:
-  16  
-  17  /**
-  18:  * @deprecated ES6: use `String.padStart`
-  19   */
-  20  export function pad(n: number, l: number, char: string = '0'): string {
-
-  147  
-  148  /**
-  149:  * @deprecated ES6: use `String.startsWith`
-  150   */
-  151  export function startsWith(haystack: string, needle: string): boolean {
-
-  168  
-  169  /**
-  170:  * @deprecated ES6: use `String.endsWith`
-  171   */
-  172  export function endsWith(haystack: string, needle: string): boolean {
+   15  
+   16  /**
+   17:  * @deprecated ES6: use `String.padStart`
+   18   */
+   19  export function pad(n: number, l: number, char: string = '0'): string {
+
+  146  
+  147  /**
+  148:  * @deprecated ES6: use `String.startsWith`
+  149   */
+  150  export function startsWith(haystack: string, needle: string): boolean {
+
+  167  
+  168  /**
+  169:  * @deprecated ES6: use `String.endsWith`
+  170   */
+  171  export function endsWith(haystack: string, needle: string): boolean {

CONTRIBUTING.md

@@ -51,9 +51,9 @@ The built-in tool for reporting an issue, which you can access by using `Report
 
 Please include the following with each issue:
 
-* Version of VS Code  
+* Version of VS Code
 
-* Your operating system  
+* Your operating system
 
 * List of extensions that you have installed
 
@@ -87,10 +87,11 @@ Once submitted, your report will go into the [issue tracking](https://github.com
 
 ## Automated Issue Management
 
-We use a bot to help us manage issues. This bot currently:
+We use GitHub Actions to help us manage issues. These Actions and their descriptions can be [viewed here](https://github.com/JacksonKearl/vscode-triage-github-actions/blob/master/README.md). Some examples of what these Actions do are:
 
 * Automatically closes any issue marked `needs-more-info` if there has been no response in the past 7 days.
-* Automatically locks issues 45 days after they are closed.
+* Automatically lock issues 45 days after they are closed.
+* Automatically implement the VS Code [feature request pipeline](https://github.com/microsoft/vscode/wiki/Issues-Triaging#managing-feature-requests).
 
 If you believe the bot got something wrong, please open a new issue and let us know.
 

build/builtInExtensions.json

@@ -46,7 +46,7 @@
 	},
 	{
 		"name": "ms-vscode.js-debug-nightly",
-		"version": "2020.3.1617",
+		"version": "2020.3.3117",
 		"forQualities": [
 			"insider"
 		],

build/lib/watch/yarn.lock

@@ -230,9 +230,9 @@ for-own@^0.1.4:
     for-in "^1.0.1"
 
 fsevents@~2.1.1:
-  version "2.1.1"
-  resolved "https://registry.yarnpkg.com/fsevents/-/fsevents-2.1.1.tgz#74c64e21df71721845d0c44fe54b7f56b82995a9"
-  integrity sha512-4FRPXWETxtigtJW/gxzEDsX1LVbPAM93VleB83kZB+ellqbHMkyt2aJfuzNLRvFPnGi6bcE5SvfxgbXPeKteJw==
+  version "2.1.2"
+  resolved "https://registry.yarnpkg.com/fsevents/-/fsevents-2.1.2.tgz#4c0a1fb34bc68e543b4b82a9ec392bfbda840805"
+  integrity sha512-R4wDiBwZ0KzpgOWetKDug1FZcYhqYnUYKtfZYt4mD5SBz76q0KR4Q9o7GIPamsVPGmW3EYPPJ0dOOjvx32ldZA==
 
 glob-base@^0.3.0:
   version "0.3.0"
@@ -258,9 +258,9 @@ glob-parent@^3.0.1:
     path-dirname "^1.0.0"
 
 glob-parent@~5.1.0:
-  version "5.1.0"
-  resolved "https://registry.yarnpkg.com/glob-parent/-/glob-parent-5.1.0.tgz#5f4c1d1e748d30cd73ad2944b3577a81b081e8c2"
-  integrity sha512-qjtRgnIVmOfnKUE3NJAQEdk+lKrxfw8t5ke7SXtfMTHcjsBfOfWXCQfdb30zfDoZQ2IRSIiidmjtbHZPZ++Ihw==
+  version "5.1.1"
+  resolved "https://registry.yarnpkg.com/glob-parent/-/glob-parent-5.1.1.tgz#b6c1ef417c4e5663ea498f1c45afac6916bbc229"
+  integrity sha512-FnI+VGOpnlGHWZxthPGR+QhR78fuiK0sNLkHQv+bL9fQi57lNNdquIbna/WrfROrolq8GK5Ek6BiMwqL/voRYQ==
   dependencies:
     is-glob "^4.0.1"
 
@@ -405,9 +405,9 @@ kind-of@^3.0.2:
     is-buffer "^1.1.5"
 
 kind-of@^6.0.0:
-  version "6.0.2"
-  resolved "https://registry.yarnpkg.com/kind-of/-/kind-of-6.0.2.tgz#01146b36a6218e64e58f3a8d66de5d7fc6f6d051"
-  integrity sha512-s5kLOcnH0XqDO+FvuaLX8DDjZ18CGFk7VygH40QoKPUQhW4e2rvM0rwUq0t8IQDOwYSeLK01U90OjzBTme2QqA==
+  version "6.0.3"
+  resolved "https://registry.yarnpkg.com/kind-of/-/kind-of-6.0.3.tgz#07c05034a6c349fa06e24fa35aa76db4580ce4dd"
+  integrity sha512-dcS1ul+9tmeD95T+x28/ehLgd9mENa3LsvDTtzm3vyBEO7RPptvAD+t44WVXaUjTBRcrpFeFlC8WCruUR456hw==
 
 math-random@^1.0.1:
   version "1.0.4"
@@ -479,9 +479,9 @@ path-is-absolute@^1.0.1:
   integrity sha1-F0uSaHNVNP+8es5r9TpanhtcX18=
 
 picomatch@^2.0.4:
-  version "2.1.0"
-  resolved "https://registry.yarnpkg.com/picomatch/-/picomatch-2.1.0.tgz#0fd042f568d08b1ad9ff2d3ec0f0bfb3cb80e177"
-  integrity sha512-uhnEDzAbrcJ8R3g2fANnSuXZMBtkpSjxTTgn2LeSiQlfmq72enQJWdQllXW24MBLYnA1SBD2vfvx2o0Zw3Ielw==
+  version "2.2.2"
+  resolved "https://registry.yarnpkg.com/picomatch/-/picomatch-2.2.2.tgz#21f333e9b6b8eaff02468f5146ea406d345f4dad"
+  integrity sha512-q0M/9eZHzmr0AulXyPwNfZjtwZ/RBZlbN3K3CErVrk50T2ASYI7Bye0EvekFY3IP1Nt2DHu0re+V2ZHIpMkuWg==
 
 pify@^2.3.0:
   version "2.3.0"
@@ -530,9 +530,9 @@ randomatic@^3.0.0:
     math-random "^1.0.1"
 
 readable-stream@^2.0.2, readable-stream@^2.2.2, readable-stream@^2.3.5:
-  version "2.3.6"
-  resolved "https://registry.yarnpkg.com/readable-stream/-/readable-stream-2.3.6.tgz#b11c27d88b8ff1fbe070643cf94b0c79ae1b0aaf"
-  integrity sha512-tQtKA9WIAhBF3+VLAseyMqZeBjW0AHJoxOtYqSUZNJxauErmLbVm2FW1y+J/YA9dUrAC39ITejlZWhVIwawkKw==
+  version "2.3.7"
+  resolved "https://registry.yarnpkg.com/readable-stream/-/readable-stream-2.3.7.tgz#1eca1cf711aef814c04f62252a36a62f6cb23b57"
+  integrity sha512-Ebho8K4jIbHAxnuxi7o42OrZgF/ZTNcsZj6nRKyUmkhLFq8CHItp/fy6hQZuZmP/n3yZ9VBUbp4zz/mX8hmYPw==
   dependencies:
     core-util-is "~1.0.0"
     inherits "~2.0.3"

extensions/git/package.json

@@ -1235,11 +1235,6 @@
         }
       ],
       "timeline/item/context": [
-        {
-          "command": "git.timeline.openDiff",
-          "group": "inline",
-          "when": "config.git.enabled && !git.missing && timelineItem =~ /git:file\\b/"
-        },
         {
           "command": "git.timeline.openDiff",
           "group": "1_timeline",

extensions/git/src/timelineProvider.ts

@@ -74,7 +74,7 @@ export class GitTimelineProvider implements TimelineProvider {
 	constructor(private readonly _model: Model) {
 		this.disposable = Disposable.from(
 			_model.onDidOpenRepository(this.onRepositoriesChanged, this),
-			workspace.registerTimelineProvider(['file', 'git', 'gitlens-git'], this),
+			workspace.registerTimelineProvider(['file', 'git', 'vscode-remote', 'gitlens-git'], this),
 		);
 	}