auto-renaming tags notifier popping up multiple times. Fixes #97833

microsoft · May 15, 2020 · 13952ac · 13952ac
1 parent 4c36782
commit 13952ac
Showing 1 changed file with 19 additions and 14 deletions.
diff --git a/extensions/html-language-features/client/src/htmlMain.ts b/extensions/html-language-features/client/src/htmlMain.ts
@@ -298,21 +298,26 @@ export function activate(context: ExtensionContext) {
 	});
 
 	const promptForTypeOnRenameKey = 'html.promptForTypeOnRename';
-	const promptForTypeOnRename =
-		!workspace.getConfiguration().get(SettingIds.renameOnType, { languageId: 'html' }) &&
-		extensions.getExtension('formulahendry.auto-rename-tag') &&
-		(context.globalState.get(promptForTypeOnRenameKey) !== false);
-
-	toDispose.push(window.onDidChangeActiveTextEditor(async e => {
-		if (e && promptForTypeOnRename && documentSelector.indexOf(e.document.languageId) !== -1) {
-			context.globalState.update(promptForTypeOnRenameKey, false);
-			const configure = localize('configureButton', 'Configure');
-			const res = await window.showInformationMessage(localize('renameOnTypeQuestion', 'VS Code now has built-in support for auto-renaming tags. Do you want to enable it?'), configure);
-			if (res === configure) {
-				commands.executeCommand('workbench.action.openSettings', SettingIds.renameOnType);
+	const promptForTypeOnRename = extensions.getExtension('formulahendry.auto-rename-tag') !== undefined &&
+		(context.globalState.get(promptForTypeOnRenameKey) !== false) &&
+		!workspace.getConfiguration('editor', { languageId: 'html' }).get('renameOnType');
+
+	if (promptForTypeOnRename) {
+		const activeEditorListener = window.onDidChangeActiveTextEditor(async e => {
+			if (e && documentSelector.indexOf(e.document.languageId) !== -1) {
+				context.globalState.update(promptForTypeOnRenameKey, false);
+				activeEditorListener.dispose();
+				const configure = localize('configureButton', 'Configure');
+				const res = await window.showInformationMessage(localize('renameOnTypeQuestion', 'VS Code now has built-in support for auto-renaming tags. Do you want to enable it?'), configure);
+				if (res === configure) {
+					commands.executeCommand('workbench.action.openSettings', SettingIds.renameOnType);
+				}
 			}
-		}
-	}));
+		});
+		toDispose.push(activeEditorListener);
+	}
+
+	toDispose.push();
 }
 
 function getPackageInfo(context: ExtensionContext): IPackageInfo | null {