Disable the "Ok" button for empty strings

Fixes #104131
microsoft · Aug 7, 2020 · 20cba51 · 20cba51
1 parent 42a9a99
commit 20cba51
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/src/vs/workbench/contrib/preferences/browser/settingsWidgets.ts b/src/vs/workbench/contrib/preferences/browser/settingsWidgets.ts
@@ -780,6 +780,7 @@ export class ObjectSettingWidget extends AbstractListSettingWidget<IObjectDataIt
 		const changedItem = { ...item };
 		const onKeyChange = (key: ObjectKey) => {
 			changedItem.key = key;
+			okButton.enabled = key.data !== '';
 
 			const suggestedValue = this.valueSuggester(key.data) ?? item.value;
 
@@ -843,6 +844,7 @@ export class ObjectSettingWidget extends AbstractListSettingWidget<IObjectDataIt
 		rowElement.append(keyElement, valueContainer);
 
 		const okButton = this._register(new Button(rowElement));
+		okButton.enabled = changedItem.key.data !== '';
 		okButton.label = localize('okButton', "OK");
 		okButton.element.classList.add('setting-list-ok-button');