-
Notifications
You must be signed in to change notification settings - Fork 27.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Transfer webview resource buffers (#139145)
* Use transferables for webview resources Fixes #139145 This updates the webview resource loading to use transferables On desktop, this requires a new way of converting the file stream to a buffer without using the nodejs backing pool * Use ArrayBuffer directly instead of using Buffer
- Loading branch information
Showing
3 changed files
with
42 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
256cc1d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mjbvz There's a typo in
browser/webviewElement::streamToBuffer
, should bevsBuffer.buffer.buffer;
as it is now loading web view resources in vscode server is broken. Created a PR with the fix #142288