Skip to content

Commit

Permalink
Fix #17468
Browse files Browse the repository at this point in the history
  • Loading branch information
@sandy081
sandy081 committed Dec 19, 2016
1 parent eda1d44 commit 31ae0d5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/vs/workbench/parts/preferences/browser/preferences.contribution.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ registry.registerWorkbenchAction(new SyncActionDescriptor(OpenGlobalSettingsActi
}), 'Preferences: Open User Settings', category);
registry.registerWorkbenchAction(new SyncActionDescriptor(OpenGlobalKeybindingsAction, OpenGlobalKeybindingsAction.ID, OpenGlobalKeybindingsAction.LABEL, { primary: KeyChord(KeyMod.CtrlCmd | KeyCode.KEY_K, KeyMod.CtrlCmd | KeyCode.KEY_S) }), 'Preferences: Open Keyboard Shortcuts', category);
registry.registerWorkbenchAction(new SyncActionDescriptor(OpenWorkspaceSettingsAction, OpenWorkspaceSettingsAction.ID, OpenWorkspaceSettingsAction.LABEL), 'Preferences: Open Workspace Settings', category);
registry.registerWorkbenchAction(new SyncActionDescriptor(StartSearchDefaultSettingsAction, StartSearchDefaultSettingsAction.ID, StartSearchDefaultSettingsAction.LABEL, { primary: KeyMod.CtrlCmd | KeyCode.KEY_F }, ContextKeyExpr.and(CONTEXT_DEFAULT_SETTINGS_EDITOR)), 'Preferences: Focus Default Settings Search', category);
registry.registerWorkbenchAction(new SyncActionDescriptor(StartSearchDefaultSettingsAction, StartSearchDefaultSettingsAction.ID, '', { primary: KeyMod.CtrlCmd | KeyCode.KEY_F }, ContextKeyExpr.and(CONTEXT_DEFAULT_SETTINGS_EDITOR)), '');

This comment has been minimized.

Sign in to view

Copy link
@bpasero

bpasero Dec 19, 2016

Member

@sandy081 fyi this looks a bit odd, instead of leaving the name empty, why not just register a command? that way you still have support for keybinding but you do not need the workaround for hiding it from the F1 list.

This comment has been minimized.

Sign in to view

Copy link
@sandy081

sandy081 Dec 20, 2016

Author Member

@bpasero I remember that not giving the label was only way to exclude an action from F1 list. But you are right registering just editor command is the right approach here. Will go for it. Thanks.

MenuRegistry.appendMenuItem(MenuId.EditorTitle, {
command: {
Expand Down

0 comments on commit 31ae0d5

Please sign in to comment.